Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from 6.6.0.0 to 7.0.4.0 stops forums list from displaying anything #243

Closed
puresystems opened this issue Feb 22, 2023 · 17 comments · Fixed by #248
Closed

Upgrade from 6.6.0.0 to 7.0.4.0 stops forums list from displaying anything #243

puresystems opened this issue Feb 22, 2023 · 17 comments · Fixed by #248
Assignees
Labels
bug Something isn't working
Milestone

Comments

@puresystems
Copy link

Describe the bug

Upgraded a test site from 6.6.0.0 to 7.0.4.0 and now none of the forums are displayed on the main Forums page. They exist in the control panel.

Software Versions

  • DNN: 9.10.2
  • Module: 7.0.4

To Reproduce

Steps to reproduce the behavior:

  1. Upgrade module from 6.6.0.0 to 7.0.4.0 using the installer
  2. View existing Forums page where the module is set to Standard Mode and ForumView template

Expected behavior

The existing forums should be displayed in list format.

Screenshots

N/A

Error log

No errors are logged in DNN log viewer or log files.

Additional context

After doing a bit more digging, running SQL profiler when the page first loads does show this query:

exec dbo.activeforums_UI_ForumView @PortalId=0,@ModuleId=649,@UserId=10,@IsSuperUser=0,@ParentForumId=-1,@ForumIds=N'10;21;25;'

Which does return results when i run it in SQL.

So it might be a templating issue maybe?

@johnhenley
Copy link
Collaborator

Hi @puresystems thanks for the issue. Can you change forum display to "default" and see if that displays the forums?

@puresystems
Copy link
Author

Hi @johnhenley - we've changed the display but it hasn't seemed to help. Interestingly, the quick forum nav drop-down doesn't contain the forums accessible and i can use this to see forum posts which work, it's just the initial Forums view which isn't working.

@johnhenley
Copy link
Collaborator

Hi @johnhenley - we've changed the display but it hasn't seemed to help. Interestingly, the quick forum nav drop-down doesn't contain the forums accessible and i can use this to see forum posts which work, it's just the initial Forums view which isn't working.

Are you saying the quick forum nav drop down is or isn't working?

@johnhenley
Copy link
Collaborator

What is your URL for the forums page?
add /aff/10 to the URL and see if you see the topics list for that forum.

@puresystems
Copy link
Author

Sorry, it should have read that the Quick Nav DOES show contain the forums.

@johnhenley
Copy link
Collaborator

Sorry, it should have read that the Quick Nav DOES show contain the forums.

Ok. That's good since it means at least the module is loading. And you're seeing content on specific forum pages, correct?

@johnhenley
Copy link
Collaborator

What theme are you using? Can you test the _default theme if haven't already?

@johnhenley
Copy link
Collaborator

Also, a screenshot of the /templates folder under whatever theme you are currently using.

@johnhenley
Copy link
Collaborator

johnhenley commented Feb 22, 2023

And just to make sure, can you check this setting for forum group(s) and forums?
image

@WillStrohl
Copy link
Member

Hello @puresystems ... Thank you for reporting this issue. DId this also happen in the Release Candidate, or are you just now attempting the upgrade?

@puresystems
Copy link
Author

@johnhenley @WillStrohl Ok, it appears to be the Hidden option for the Groups which was causing this. By making the Groups unhidden, it now shows the accessible forums to the user. I guess the behaviour may have changed with this. I think previously, if we didn't Hide the groups, then a user would see all the group Headings but not the forums if they didn't have access to them. Thanks for your help.

@johnhenley
Copy link
Collaborator

@johnhenley @WillStrohl Ok, it appears to be the Hidden option for the Groups which was causing this. By making the Groups unhidden, it now shows the accessible forums to the user. I guess the behaviour may have changed with this. I think previously, if we didn't Hide the groups, then a user would see all the group Headings but not the forums if they didn't have access to them. Thanks for your help.

Interesting. I think the way you had it set up is the intended behavior so this might be a bug. I will do some investigating and report back.

@johnhenley johnhenley added the review in process Issue noted and currently being triaged/reviewed by developer label Feb 23, 2023
@johnhenley johnhenley self-assigned this Feb 23, 2023
@WillStrohl
Copy link
Member

Thank you both, @johnhenley & @puresystems ... We definitely don't intend to release a breaking change like this in a version of this context. :(

@johnhenley
Copy link
Collaborator

Looks like this was actually a bug introduced when the project was converted from VB.Net to C#, but it only surfaced after the integration with Active Social was removed in 07.00.04. Long story short, I have a pull request waiting, and @WillStrohl can decide if it should go into the current 07.00.05 RC or how to release it.

@WillStrohl
Copy link
Member

@johnhenley What are the impacts from your perspective on including this bug fix in 7.0.5 RC versus waiting until 7.0.6?

@johnhenley johnhenley added bug Something isn't working and removed review in process Issue noted and currently being triaged/reviewed by developer labels Feb 23, 2023
@johnhenley
Copy link
Collaborator

@johnhenley What are the impacts from your perspective on including this bug fix in 7.0.5 RC versus waiting until 7.0.6?

I don't know how many use that feature but it should be able to wait as long as it has been identified, there is a workaround, and fix is in next release. @puresystems do you agree?

@puresystems
Copy link
Author

@johnhenley We don't mind waiting as it's not affecting live sites yet as we've not upgraded these yet.

@johnhenley johnhenley added this to the 07.00.06 milestone Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants