Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supporting code for Web API implementation #268

Merged
merged 13 commits into from
Apr 13, 2023
Merged

Supporting code for Web API implementation #268

merged 13 commits into from
Apr 13, 2023

Conversation

johnhenley
Copy link
Collaborator

@johnhenley johnhenley commented Mar 31, 2023 •
edited
Loading

Description of PR...

Add some supporting code for Web API implementation

Changes made

  • Add DotNetNuke.Modules.ActiveForums.Services namespace, and adjust existing code that refers to "Services." to be prefixed by DotNetNuke.Services. to avoid namespace issues.
  • Rename ForumRouteMapper to RouteMapper to be consistent with other projects
  • Updates RouteMapper to include DotNetNuke.Modules.ActiveForums.Services.Controllers namespace
  • Adds ForumsAuthorizeAttribute for use by Web APIs to specify which forum permission to apply; APIs can be decorated with this attribute in order to apply forum security:
    image
  • ControllerBase

PR Template Checklist

  • Fixes Bug
  • Feature solution
  • Other

Please mark which issue is related

Related to epic issue #53

@johnhenley johnhenley added the enhancement New feature or request label Mar 31, 2023
@johnhenley johnhenley added this to the 07.00.07 milestone Mar 31, 2023
@johnhenley johnhenley self-assigned this Mar 31, 2023
@johnhenley
Copy link
Collaborator Author

johnhenley commented Mar 31, 2023 •
edited
Loading

@WillStrohl I put this into next release (07.07.00) since it's fairly small and we can start getting the forum services handlers converted to web api :)

WillStrohl
WillStrohl approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@WillStrohl WillStrohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! :)

@WillStrohl WillStrohl merged commit 689f301 into DNNCommunity:dev Apr 13, 2023
@johnhenley johnhenley deleted the issues/53/53a branch May 2, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillStrohl WillStrohl WillStrohl approved these changes

Assignees

@johnhenley johnhenley

Labels
enhancement New feature or request
Projects
None yet
Milestone
07.00.07
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@johnhenley @WillStrohl