Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nothing Appears to Happen When Deleting a Topic w/ No Replies #390

Closed
WillStrohl opened this issue Jul 24, 2023 · 2 comments · Fixed by #740
Closed

Nothing Appears to Happen When Deleting a Topic w/ No Replies #390

WillStrohl opened this issue Jul 24, 2023 · 2 comments · Fixed by #740
Assignees
Labels
bug Something isn't working
Milestone

Comments

@WillStrohl
Copy link
Member

WillStrohl commented Jul 24, 2023

Describe the bug

When you come across a forum post that doesn't belong in your community, you might be inclined to delete it immediately. When you do this in a topic that has multiple replies, it works exactly as you'd expect. When you do this in a topic that hasn't yet received a reply, it doesn't appear to do what you'd expect.

Software Versions

  • DNN: 09.12.00
  • Module: 07.00.12

To Reproduce

Steps to reproduce the behavior:

  1. Clean install of DNN and the forums module.
  2. Add the forums module on a new page, and go through the getting started step.
  3. Go into any forum and create a new topic. (Probably best to do this as a separate user, but it shouldn't matter.)
  4. Now delete the newly posted topic.
  5. Click the OK button to confirm that you wish to delete the post.

Expected behavior

The post is deleted, as well as the topic since they're the same at this point. You're redirected to the forum root, or the parent category of that post. There might even be a success message of some kind.

In actuality, what should be happening with the current feature set is that you're redirected to the root of the forums module.

Actual Behavior

The post is indeed deleted, but nothing else happens. You're not redirected. The message is still in front of you. The only way you'd know it worked is if you refresh the page, or exit and navigate back the way you originally arrived at the page.

Screenshots

image

Error log

N/A

Additional context

N/A

@WillStrohl WillStrohl added the bug Something isn't working label Jul 24, 2023
@johnhenley
Copy link
Collaborator

@WillStrohl I didn't laugh until I looked at this JavaScript after you delete. We can revamp this when this function gets moved to web api (which should be soon)?
image

@WillStrohl
Copy link
Member Author

Oh wow... That's quite a line of code right there! 🤣

@johnhenley johnhenley self-assigned this Dec 1, 2023
@johnhenley johnhenley added this to the 08.01.00 milestone Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants