Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: HTML structure > Use Heading instead of span with class 'aftitlelg" #457

Closed
Timo-Breumelhof opened this issue Sep 15, 2023 · 2 comments · Fixed by #464
Closed

ENH: HTML structure > Use Heading instead of span with class 'aftitlelg" #457

Timo-Breumelhof opened this issue Sep 15, 2023 · 2 comments · Fixed by #464
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@Timo-Breumelhof
Copy link
Contributor

Timo-Breumelhof commented Sep 15, 2023

Describe the bug

In 4 places the module uses a span with a class and CSS to make the text larger.
For consistency / styling and accessibility it's better to use a heading as that's what it is

Software Versions

  • DNN: 08.00.00
  • Module: 09.10.02

To Reproduce

Steps to reproduce the behavior:

  1. Search the solution for aftitlelg
  2. You will find 4 cases of this <asp:Label ID="lblHeader" CssClass="aftitlelg" runat="server" />

Expected behavior

Use h1-6 for headings

Solution

I suggest we wrap the label like this:

<h3 class="dcf-heading-3"><asp:Label ID="lblHeader" CssClass="aftitlelg" runat="server" /></h3>

So we keep the old class as a fallback.
This is a subheading inside the module where h3 seems the most appropriate?

Screenshots

image

@Timo-Breumelhof Timo-Breumelhof added the enhancement New feature or request label Sep 15, 2023
@Timo-Breumelhof Timo-Breumelhof added this to the 09.00.00 milestone Sep 15, 2023
@Timo-Breumelhof Timo-Breumelhof self-assigned this Sep 15, 2023
@johnhenley
Copy link
Collaborator

Good suggestion. Do you want me to do this?

@Timo-Breumelhof
Copy link
Contributor Author

@johnhenley Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants