BUG: Place new module leads to two modules?

[Timo-Breumelhof]

Describe the bug

When I placing a DNN module, normally there's a floating box to place it.
When I do this with the Forums module I also see the module already placed and when I drop the floating Icon, I have two modules.

Software Versions

• DNN: 08.00.00 (upgraded)
• Module: 09.10.01

To Reproduce

Steps to reproduce the behavior:

1. Place the Community Forums Module
2. See:

Result:

Expected behavior

One module should be placed

Can others reproduce this?

[Timo-Breumelhof]

Caused by having two module definitions in one?

[Timo-Breumelhof]

FYI, I also see this in moduledefinitions:

"Viewer" and "What's new" still have the old name

[Timo-Breumelhof]

Ok, I'll try a fresh upgrade later as it might be caused by me installing 8.0.0 10 times

[johnhenley]

@Timo-Breumelhof I was able to duplicate this; it's a scenario we didn't catch during upgrade testing. We tested 7->8 upgrade of an existing module, and v8 fresh install; both resulted in correct behavior.

What we didn't test was an existing v7, upgraded to v8, and then adding the module to a page (I guess I naively assumed that if you had v7 and are upgrading to v8, you already have a forums module running, and wouldn't need to install another one.

As you remember, renaming the module and allowing for both an upgrade (7->future for "Active Forums AND 8-> future for "DNN Community Forums") required some manipulation of the module and package names. There was also a challenge with how the installer works with SQL updates and IUpgradeable when skipping versions (i.e. 07.00.11 -> 08.00.01). The "Active Forums" module is required for anyone upgrading from any version. Otherwise "DNN Community Forums"--being different from "Active Forums"--ALL of the SqlDataProvider scripts are executed. Since some of them are not "defensive" they end up failing since a lot of objects already exist.
The scenario as duplicated is 1) install 7.0.12, then install 8.00.01. That results in two ModuleDefinitions as you noted, and duplicates the module when you put it onto a page. I will try to fix this for 08.01.00.

[Timo-Breumelhof]

@johnhenley I noticed an issue with the fix I think.
After I upgrade the module to 08.01.00 the exiting Forums module is gone.
I guess the module was placed as "Active Forums, which does not exist any more after the upgrade ?
08.01.00 built from dev. and installed on my test site.. (over 08.00.01)

[johnhenley]

@johnhenley I noticed an issue with the fix I think.

After I upgrade the module to 08.01.00 the exiting Forums module is gone.

I guess the module was placed as "Active Forums, which does not exist any more after the upgrade ?

08.01.00 built from dev. and installed on my test site.. (over 08.00.01)

@Timo-Breumelhof I will retest and see what I can figure out. Seems like this is going to keep haunting me :)

[johnhenley]

@johnhenley I noticed an issue with the fix I think.
After I upgrade the module to 08.01.00 the exiting Forums module is gone.
I guess the module was placed as "Active Forums, which does not exist any more after the upgrade ?
08.01.00 built from dev. and installed on my test site.. (over 08.00.01)

@Timo-Breumelhof I will retest and see what I can figure out. Seems like this is going to keep haunting me :)

@Timo-Breumelhof I was able to duplicate this, using these steps:

• Install 07.00.12

• Install 08.00.01

• Place forums module on page, and creates two modules:
  

• Delete the first one (DNN Community Forums) but leave the second one (Active Forums)

• Install 08.01.00

• It will delete the second one (Active Forums)

will update when this is fixed.

[johnhenley]

@Timo-Breumelhof fix is in PR #731