Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent toolbar overcrowding #703

Closed
Timo-Breumelhof opened this issue Mar 11, 2024 · 6 comments · Fixed by #796
Closed

Prevent toolbar overcrowding #703

Timo-Breumelhof opened this issue Mar 11, 2024 · 6 comments · Fixed by #796
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@Timo-Breumelhof
Copy link
Contributor

Is your feature request related to a problem?

Please describe.
As we add more filters to the toolbar, this also makes it less clear due to overcrowding the toolbar.

Describe the solution you'd like

I think we could add a filter link with an (html css) dropdown, containing

  • unanswered
  • not read
  • Announcements
  • active topics
  • most liked
  • most replies

image

The only disadvantage I see that from a Forum manager point of view it would be nice if you could set what ends up where.
But I guess that's for a later stage..

Describe alternatives you've considered

none

Additional context

see also #701

@johnhenley
Copy link
Collaborator

@Timo-Breumelhof that would be great. An administrator has control--since toolbar is templated--over which filters they want to display.

@johnhenley
Copy link
Collaborator

Since toolbar is a template, can it all be done within the template without any code changes?

@Timo-Breumelhof Timo-Breumelhof added this to the 08.01.00 milestone Mar 11, 2024
@Timo-Breumelhof
Copy link
Contributor Author

I think so, I'll have a look

@johnhenley johnhenley modified the milestones: 08.01.00, 08.02.00 Apr 19, 2024
@Timo-Breumelhof
Copy link
Contributor Author

@johnhenley what do you think.. (where to add the JS)
A. Make part of the module
B. Make is part of the themes

Or maybe re-use the code for the panel collapse?

@johnhenley
Copy link
Collaborator

johnhenley commented Apr 22, 2024

@johnhenley what do you think.. (where to add the JS)

A. Make part of the module

B. Make is part of the themes

Or maybe re-use the code for the panel collapse?

It's just html and css as part of toolbar template and goes in the theme imho. The module shouldn't dictate what is shown. For example, "most likes" or "announcements" might not be relevant if a site doesn't use those features so they could be commented out or removed from template in the sites's theme. The html goes in the toolbar.ascx template, in config/templates, with (potential override) in themes. The CSS for drop-down goes in module.css but designer can override in their theme.css if they want different colors or behavior or styles. Does that make sense? Would you like me to try and work on this?

@Timo-Breumelhof
Copy link
Contributor Author

I'll first built it and then we'll decide :-) @johnhenley

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants