-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent toolbar overcrowding #703
Comments
@Timo-Breumelhof that would be great. An administrator has control--since toolbar is templated--over which filters they want to display. |
Since toolbar is a template, can it all be done within the template without any code changes? |
I think so, I'll have a look |
@johnhenley what do you think.. (where to add the JS) Or maybe re-use the code for the panel collapse? |
It's just html and css as part of toolbar template and goes in the theme imho. The module shouldn't dictate what is shown. For example, "most likes" or "announcements" might not be relevant if a site doesn't use those features so they could be commented out or removed from template in the sites's theme. The html goes in the toolbar.ascx template, in config/templates, with (potential override) in themes. The CSS for drop-down goes in module.css but designer can override in their theme.css if they want different colors or behavior or styles. Does that make sense? Would you like me to try and work on this? |
I'll first built it and then we'll decide :-) @johnhenley |
Is your feature request related to a problem?
Please describe.
As we add more filters to the toolbar, this also makes it less clear due to overcrowding the toolbar.
Describe the solution you'd like
I think we could add a filter link with an (html css) dropdown, containing
The only disadvantage I see that from a Forum manager point of view it would be nice if you could set what ends up where.
But I guess that's for a later stage..
Describe alternatives you've considered
none
Additional context
see also #701
The text was updated successfully, but these errors were encountered: