-
Notifications
You must be signed in to change notification settings - Fork 16
/
test_tasks_ingestCrossref442Articles.py
2179 lines (1656 loc) · 76.9 KB
/
test_tasks_ingestCrossref442Articles.py
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
import ftplib
import os
import requests
import time
from urllib.parse import urlparse
from lxml import etree
from doajtest import test_constants
from doajtest.fixtures import ArticleFixtureFactory, AccountFixtureFactory
from doajtest.fixtures.article_crossref import Crossref442ArticleFixtureFactory
from doajtest.helpers import DoajTestCase
from doajtest.mocks.bll_article import BLLArticleMockFactory
from doajtest.mocks.file import FileMockFactory
from doajtest.mocks.ftp import FTPMockFactory
from doajtest.mocks.response import ResponseMockFactory
from doajtest.mocks.xwalk import XwalkMockFactory
from portality import models
from portality.background import BackgroundException
from portality.bll.exceptions import IngestException
from portality.bll.services import article as articleSvc
from portality.core import app
from portality.crosswalks import article_crossref_xml
from portality.tasks import ingestarticles
from portality.ui.messages import Messages
ARTICLES = test_constants.PATH_RESOURCES / "crossref442_article_uploads.xml"
class TestIngestArticlesCrossref442XML(DoajTestCase):
@classmethod
def setUpClass(self):
super(TestIngestArticlesCrossref442XML, self).setUpClass()
schema_path = app.config.get("SCHEMAS", {}).get("crossref442")
schema_file = open(schema_path)
schema_doc = etree.parse(schema_file)
self.schema = etree.XMLSchema(schema_doc)
def setUp(self):
super(TestIngestArticlesCrossref442XML, self).setUp()
self.cleanup_ids = []
self.cleanup_paths = []
self.schema_old = etree.XMLSchema
self.xwalk_validate = article_crossref_xml.CrossrefXWalk442.validate
self.batch_create_articles = articleSvc.ArticleService.batch_create_articles
self.head = requests.head
self.get = requests.get
self.ftp = ftplib.FTP
self.upload_dir = app.config["UPLOAD_DIR"]
self.ingest_articles_retries = app.config['HUEY_TASKS']['ingest_articles']['retries']
def tearDown(self):
super(TestIngestArticlesCrossref442XML, self).tearDown()
requests.head = self.head
requests.get = self.get
ftplib.FTP = self.ftp
etree.XMLSchema = self.schema_old
article_crossref_xml.CrossrefXWalk442.validate = self.xwalk_validate
articleSvc.ArticleService.batch_create_articles = self.batch_create_articles
app.config["UPLOAD_DIR"] = self.upload_dir
app.config["HUEY_TASKS"]["ingest_articles"]["retries"] = self.ingest_articles_retries
for id in self.cleanup_ids:
path = os.path.join(app.config.get("UPLOAD_DIR", "."), id + ".xml")
if os.path.exists(path):
os.remove(path)
for id in self.cleanup_ids:
path = os.path.join(app.config.get("FAILED_ARTICLE_DIR", "."), id + ".xml")
if os.path.exists(path):
os.remove(path)
for path in self.cleanup_paths:
if os.path.exists(path):
os.remove(path)
def mock_load_schema(self, doc):
return self.schema
@classmethod
def mock_unable_to_upload_schema(cls, doc):
raise IngestException(u"Unable to load schema")
def test_01_crossref_file_upload_success(self):
etree.XMLSchema = self.mock_load_schema
handle = Crossref442ArticleFixtureFactory.upload_1_issn_correct()
f = FileMockFactory(stream=handle)
previous = []
id = ingestarticles.IngestArticlesBackgroundTask._file_upload("testuser", f, "crossref442", previous)
self.cleanup_ids.append(id)
fu = models.FileUpload.pull(id)
assert fu is not None
assert fu.schema == "crossref442"
assert fu.status == "validated"
path = os.path.join(app.config.get("UPLOAD_DIR", "."), id + ".xml")
assert os.path.exists(path)
assert len(previous) == 1
def test_02_crossref_file_upload_invalid(self):
etree.XMLSchema = self.mock_load_schema
handle = Crossref442ArticleFixtureFactory.invalid_schema_xml()
f = FileMockFactory(stream=handle)
previous = []
with self.assertRaises(BackgroundException):
id = ingestarticles.IngestArticlesBackgroundTask._file_upload("testuser", f, "crossref442", previous)
assert len(previous) == 1
id = previous[0].id
self.cleanup_ids.append(id)
fu = models.FileUpload.pull(id)
assert fu is not None
assert fu.status == "failed"
assert fu.error is not None and fu.error != ""
assert fu.error_details is not None and fu.error != ""
assert list(fu.failure_reasons.keys()) == []
# file should have been removed from upload dir
path = os.path.join(app.config.get("UPLOAD_DIR", "."), id + ".xml")
assert not os.path.exists(path)
# and placed into the failed dir
fad = os.path.join(app.config.get("FAILED_ARTICLE_DIR", "."), id + ".xml")
assert os.path.exists(fad)
def test_03_crossref_file_upload_fail(self):
article_crossref_xml.CrossrefXWalk442.validate = XwalkMockFactory.validate
etree.XMLSchema = self.mock_load_schema
handle = Crossref442ArticleFixtureFactory.upload_1_issn_correct()
f = FileMockFactory(stream=handle)
previous = []
with self.assertRaises(BackgroundException):
id = ingestarticles.IngestArticlesBackgroundTask._file_upload("testuser", f, "crossref442", previous)
assert len(previous) == 1
id = previous[0].id
self.cleanup_ids.append(id)
fu = models.FileUpload.pull(id)
assert fu is not None
assert fu.status == "failed"
assert fu.error is not None and fu.error != ""
assert fu.error_details is None
assert list(fu.failure_reasons.keys()) == []
# file should have been removed from disk
path = os.path.join(app.config.get("UPLOAD_DIR", "."), id + ".xml")
assert not os.path.exists(path)
def test_04_crossref_url_upload_http_success(self):
# first try with a successful HEAD request
requests.head = ResponseMockFactory.head_success
requests.get = ResponseMockFactory.crossref442_get_success
etree.XMLSchema = self.mock_load_schema
url = "http://success"
previous = []
id = ingestarticles.IngestArticlesBackgroundTask._url_upload("testuser", url, "crossref442", previous)
fu = models.FileUpload.pull(id)
assert fu is not None
assert fu.schema == "crossref442"
assert fu.status == "exists"
assert len(previous) == 1
# try that again, but with an unsuccessful HEAD request
requests.head = ResponseMockFactory.head_fail
previous = []
id = ingestarticles.IngestArticlesBackgroundTask._url_upload("testuser", url, "crossref442", previous)
fu = models.FileUpload.pull(id)
assert fu is not None
assert fu.schema == "crossref442"
assert fu.status == "exists"
assert len(previous) == 1
def test_05_crossref_url_upload_http_fail(self):
# try with failing http requests
requests.head = ResponseMockFactory.head_fail
requests.get = ResponseMockFactory.get_fail
etree.XMLSchema = self.mock_load_schema
url = "http://fail"
previous = []
with self.assertRaises(BackgroundException):
id = ingestarticles.IngestArticlesBackgroundTask._url_upload("testuser", url, "crossref442", previous)
assert len(previous) == 1
id = previous[0].id
fu = models.FileUpload.pull(id)
assert fu is not None
assert fu.status == "failed"
assert fu.error is not None and fu.error != ""
assert fu.error_details is None
assert list(fu.failure_reasons.keys()) == []
# now try again with an invalid url
requests.head = ResponseMockFactory.head_success
url = "other://url"
previous = []
with self.assertRaises(BackgroundException):
id = ingestarticles.IngestArticlesBackgroundTask._url_upload("testuser", url, "crossref442", previous)
assert len(previous) == 1
id = previous[0].id
fu = models.FileUpload.pull(id)
assert fu is not None
assert fu.status == "failed"
assert fu.error is not None and fu.error != ""
assert fu.error_details is None
assert list(fu.failure_reasons.keys()) == []
def test_06_crossref_url_upload_ftp_success(self):
ftplib.FTP = FTPMockFactory.create(schema="crossref442")
previous = []
url = "ftp://success"
etree.XMLSchema = self.mock_load_schema
id = ingestarticles.IngestArticlesBackgroundTask._url_upload("testuser", url, "crossref442", previous)
fu = models.FileUpload.pull(id)
assert fu is not None
assert fu.schema == "crossref442"
assert fu.status == "exists"
assert len(previous) == 1
def test_07_url_upload_ftp_fail(self):
ftplib.FTP = FTPMockFactory.create(schema="crossref442")
previous = []
url = "ftp://fail"
with self.assertRaises(BackgroundException):
id = ingestarticles.IngestArticlesBackgroundTask._url_upload("testuser", url, "crossref442", previous)
assert len(previous) == 1
id = previous[0].id
fu = models.FileUpload.pull(id)
assert fu is not None
assert fu.status == "failed"
assert fu.error is not None and fu.error != ""
assert fu.error_details is None
assert list(fu.failure_reasons.keys()) == []
def test_08_crossref_prepare_file_upload_success(self):
handle = Crossref442ArticleFixtureFactory.upload_1_issn_correct()
f = FileMockFactory(stream=handle)
etree.XMLSchema = self.mock_load_schema
previous = []
job = ingestarticles.IngestArticlesBackgroundTask.prepare("testuser", upload_file=f, schema="crossref442",
previous=previous)
assert job is not None
assert "ingest_articles__file_upload_id" in job.params
id = job.params.get("ingest_articles__file_upload_id")
self.cleanup_ids.append(id)
assert len(previous) == 1
fu = models.FileUpload.pull(id)
assert fu is not None
def test_09_prepare_file_upload_fail(self):
article_crossref_xml.CrossrefXWalk442.validate = XwalkMockFactory.validate
handle = Crossref442ArticleFixtureFactory.upload_1_issn_correct()
f = FileMockFactory(stream=handle)
etree.XMLSchema = self.mock_load_schema
previous = []
with self.assertRaises(BackgroundException):
job = ingestarticles.IngestArticlesBackgroundTask.prepare("testuser", upload_file=f, schema="crossref442",
previous=previous)
assert len(previous) == 1
id = previous[0].id
self.cleanup_ids.append(id)
fu = models.FileUpload.pull(id)
assert fu is not None
def test_10_prepare_url_upload_success(self):
requests.head = ResponseMockFactory.head_success
url = "http://success"
requests.get = ResponseMockFactory.crossref442_get_success
etree.XMLSchema = self.mock_load_schema
previous = []
job = ingestarticles.IngestArticlesBackgroundTask.prepare("testuser", url=url, schema="crossref442", previous=previous)
assert job is not None
assert "ingest_articles__file_upload_id" in job.params
id = job.params.get("ingest_articles__file_upload_id")
self.cleanup_ids.append(id)
assert len(previous) == 1
fu = models.FileUpload.pull(id)
assert fu is not None
def test_11_prepare_url_upload_fail(self):
# try with failing http requests
requests.head = ResponseMockFactory.head_fail
requests.get = ResponseMockFactory.get_fail
url = "http://fail"
previous = []
etree.XMLSchema = self.mock_load_schema
with self.assertRaises(BackgroundException):
job = ingestarticles.IngestArticlesBackgroundTask.prepare("testuser", url=url, schema="crossref442",
previous=previous)
assert len(previous) == 1
id = previous[0].id
self.cleanup_ids.append(id)
fu = models.FileUpload.pull(id)
assert fu is not None
def test_12_prepare_parameter_errors(self):
etree.XMLSchema = self.mock_load_schema
# no url or file upload
with self.assertRaises(BackgroundException):
job = ingestarticles.IngestArticlesBackgroundTask.prepare("testuser", schema="crossref442", previous=[])
# no schema
with self.assertRaises(BackgroundException):
job = ingestarticles.IngestArticlesBackgroundTask.prepare("testuser", url="http://whatever", previous=[])
# upload dir not configured
del app.config["UPLOAD_DIR"]
with self.assertRaises(BackgroundException):
job = ingestarticles.IngestArticlesBackgroundTask.prepare("testuser", url="http://whatever", schema="doaj", previous=[])
def test_13_ftp_upload_success(self):
etree.XMLSchema = self.mock_load_schema
ftplib.FTP = FTPMockFactory.create(schema="crossref442")
file_upload = models.FileUpload()
file_upload.set_id()
upload_dir = app.config.get("UPLOAD_DIR")
path = os.path.join(upload_dir, file_upload.local_filename)
self.cleanup_paths.append(path)
url= "ftp://upload"
parsed_url = urlparse(url)
job = models.BackgroundJob()
result = ingestarticles.ftp_upload(job, path, parsed_url, file_upload)
assert result is True
assert os.path.exists(path)
assert file_upload.status == "downloaded"
def test_14_ftp_upload_fail(self):
etree.XMLSchema = self.mock_load_schema
ftplib.FTP = FTPMockFactory.create(schema="crossref442")
file_upload = models.FileUpload()
file_upload.set_id()
upload_dir = app.config.get("UPLOAD_DIR")
path = os.path.join(upload_dir, file_upload.local_filename)
self.cleanup_paths.append(path)
url = "ftp://fail"
parsed_url = urlparse(url)
job = models.BackgroundJob()
result = ingestarticles.ftp_upload(job, path, parsed_url, file_upload)
assert result is False
assert file_upload.status == "failed"
assert file_upload.error is not None and file_upload.error != ""
assert file_upload.error_details is None
assert list(file_upload.failure_reasons.keys()) == []
def test_15_http_upload_success(self):
etree.XMLSchema = self.mock_load_schema
requests.head = ResponseMockFactory.head_fail
requests.get = ResponseMockFactory.crossref442_get_success
url= "http://upload"
file_upload = models.FileUpload()
file_upload.set_id()
file_upload.upload("testuser", url, status="exists")
upload_dir = app.config.get("UPLOAD_DIR")
path = os.path.join(upload_dir, file_upload.local_filename)
self.cleanup_paths.append(path)
job = models.BackgroundJob()
result = ingestarticles.http_upload(job, path, file_upload)
assert result is True
assert os.path.exists(path)
assert file_upload.status == "downloaded"
def test_17_crossref_download_http_valid(self):
etree.XMLSchema = self.mock_load_schema
requests.head = ResponseMockFactory.head_fail
requests.get = ResponseMockFactory.crossref442_get_success
job = models.BackgroundJob()
task = ingestarticles.IngestArticlesBackgroundTask(job)
url = "http://valid"
file_upload = models.FileUpload()
file_upload.set_id()
file_upload.upload("testuser", url, status="exists")
file_upload.set_schema("crossref442")
upload_dir = app.config.get("UPLOAD_DIR")
path = os.path.join(upload_dir, file_upload.local_filename)
self.cleanup_paths.append(path)
print(file_upload)
result = task._download(file_upload)
print(result)
assert result is True
assert file_upload.status == "validated"
def test_18_download_http_invalid(self):
etree.XMLSchema = self.mock_load_schema
requests.head = ResponseMockFactory.head_fail
requests.get = ResponseMockFactory.crossref442_get_success
job = models.BackgroundJob()
url = "http://upload"
requests.get = ResponseMockFactory.crossref442_get_success
file_upload = models.FileUpload()
file_upload.set_id()
file_upload.upload("testuser", url, status="exists")
file_upload.set_schema("crossref442")
upload_dir = app.config.get("UPLOAD_DIR")
path = os.path.join(upload_dir, file_upload.local_filename)
self.cleanup_paths.append(path)
self.cleanup_ids.append(file_upload.id)
task = ingestarticles.IngestArticlesBackgroundTask(job)
result = task._download(file_upload)
assert file_upload.status == "failed"
assert file_upload.error is not None and file_upload.error != ""
assert file_upload.error_details is not None and file_upload.error_details != ""
assert list(file_upload.failure_reasons.keys()) == []
def test_19_download_http_error(self):
etree.XMLSchema = self.mock_load_schema
requests.head = ResponseMockFactory.head_fail
requests.get = ResponseMockFactory.get_fail
job = models.BackgroundJob()
url = "http://fail"
file_upload = models.FileUpload()
file_upload.set_id()
file_upload.upload("testuser", url, status="exists")
file_upload.set_schema("crossref442")
upload_dir = app.config.get("UPLOAD_DIR")
path = os.path.join(upload_dir, file_upload.local_filename)
self.cleanup_paths.append(path)
task = ingestarticles.IngestArticlesBackgroundTask(job)
result = task._download(file_upload)
assert result is False
assert file_upload.status == "failed"
assert file_upload.error is not None and file_upload.error != ""
assert file_upload.error_details is None
assert list(file_upload.failure_reasons.keys()) == []
def test_20_download_ftp_valid(self):
etree.XMLSchema = self.mock_load_schema
job = models.BackgroundJob()
url = "ftp://valid"
ftplib.FTP = FTPMockFactory.create(schema="crossref442")
file_upload = models.FileUpload()
file_upload.set_id()
file_upload.upload("testuser", url, status="exists")
file_upload.set_schema("crossref442")
upload_dir = app.config.get("UPLOAD_DIR")
path = os.path.join(upload_dir, file_upload.local_filename)
self.cleanup_paths.append(path)
task = ingestarticles.IngestArticlesBackgroundTask(job)
result = task._download(file_upload)
assert result is True
assert file_upload.status == "validated"
def test_21_download_ftp_invalid(self):
etree.XMLSchema = self.mock_load_schema
job = models.BackgroundJob()
url = "ftp://upload"
ftplib.FTP = FTPMockFactory.create(schema="crossref442")
file_upload = models.FileUpload()
file_upload.set_id()
file_upload.upload("testuser", url, status="exists")
file_upload.set_schema("crossref442")
upload_dir = app.config.get("UPLOAD_DIR")
path = os.path.join(upload_dir, file_upload.local_filename)
self.cleanup_paths.append(path)
self.cleanup_ids.append(file_upload.id)
task = ingestarticles.IngestArticlesBackgroundTask(job)
result = task._download(file_upload)
assert file_upload.status == "failed"
assert file_upload.error is not None and file_upload.error != ""
assert file_upload.error_details is not None and file_upload.error_details != ""
assert list(file_upload.failure_reasons.keys()) == []
def test_22_download_ftp_error(self):
etree.XMLSchema = self.mock_load_schema
job = models.BackgroundJob()
url = "ftp://fail"
ftplib.FTP = FTPMockFactory.create(schema="crossref442")
file_upload = models.FileUpload()
file_upload.set_id()
file_upload.upload("testuser", url, status="exists")
file_upload.set_schema("crossref442")
upload_dir = app.config.get("UPLOAD_DIR")
path = os.path.join(upload_dir, file_upload.local_filename)
self.cleanup_paths.append(path)
task = ingestarticles.IngestArticlesBackgroundTask(job)
result = task._download(file_upload)
assert result is False
assert file_upload.status == "failed"
assert file_upload.error is not None and file_upload.error != ""
assert file_upload.error_details is None
assert list(file_upload.failure_reasons.keys()) == []
def test_23_crossref_process_success(self):
etree.XMLSchema = self.mock_load_schema
j = models.Journal()
j.set_owner("testowner")
bj = j.bibjson()
bj.add_identifier(bj.P_ISSN, "1234-5678")
j.set_in_doaj(True)
j.save()
asource = AccountFixtureFactory.make_publisher_source()
account = models.Account(**asource)
account.set_id("testowner")
account.save()
# push an article to initialise the mappings
source = ArticleFixtureFactory.make_article_source()
article = models.Article(**source)
article.save(blocking=True)
article.delete()
models.Article.blockdeleted(article.id)
job = models.BackgroundJob()
file_upload = models.FileUpload()
file_upload.set_id()
file_upload.set_schema("crossref442")
file_upload.upload("testowner", "filename.xml")
upload_dir = app.config.get("UPLOAD_DIR")
path = os.path.join(upload_dir, file_upload.local_filename)
self.cleanup_paths.append(path)
stream = Crossref442ArticleFixtureFactory.upload_1_issn_correct()
with open(path, "wb") as f:
f.write(stream.read())
task = ingestarticles.IngestArticlesBackgroundTask(job)
task._process(file_upload)
assert not os.path.exists(path)
assert file_upload.status == "processed"
assert file_upload.imported == 1
assert file_upload.new == 1
def test_24_process_invalid_file(self):
etree.XMLSchema = self.mock_load_schema
j = models.Journal()
j.set_owner("testowner")
bj = j.bibjson()
bj.add_identifier(bj.P_ISSN, "1234-5678")
j.save(blocking=True)
job = models.BackgroundJob()
file_upload = models.FileUpload()
file_upload.set_id()
file_upload.set_schema("crossref442")
upload_dir = app.config.get("UPLOAD_DIR")
path = os.path.join(upload_dir, file_upload.local_filename)
self.cleanup_paths.append(path)
self.cleanup_ids.append(file_upload.id)
stream = Crossref442ArticleFixtureFactory.invalid_schema_xml()
with open(path, "w") as f:
f.write(stream.read())
task = ingestarticles.IngestArticlesBackgroundTask(job)
task._process(file_upload)
assert not os.path.exists(path)
assert file_upload.status == "failed"
assert file_upload.error is not None and file_upload.error != ""
assert file_upload.error_details is not None and file_upload.error_details != ""
assert list(file_upload.failure_reasons.keys()) == []
def test_25_process_filesystem_error(self):
etree.XMLSchema = self.mock_load_schema
articleSvc.ArticleService.batch_create_articles = BLLArticleMockFactory.batch_create
j = models.Journal()
j.set_owner("testowner")
bj = j.bibjson()
bj.add_identifier(bj.P_ISSN, "1234-5678")
j.save(blocking=True)
job = models.BackgroundJob()
file_upload = models.FileUpload()
file_upload.set_id()
file_upload.set_schema("crossref442")
upload_dir = app.config.get("UPLOAD_DIR")
path = os.path.join(upload_dir, file_upload.local_filename)
self.cleanup_paths.append(path)
self.cleanup_ids.append(file_upload.id)
stream = Crossref442ArticleFixtureFactory.upload_1_issn_correct()
with open(path, "wb") as f:
f.write(stream.read())
task = ingestarticles.IngestArticlesBackgroundTask(job)
task._process(file_upload)
assert not os.path.exists(path)
assert file_upload.status == "failed"
assert file_upload.error is not None and file_upload.error != ""
assert file_upload.error_details is None
assert list(file_upload.failure_reasons.keys()) == []
def test_26_run_validated(self):
etree.XMLSchema = self.mock_load_schema
j = models.Journal()
j.set_owner("testowner")
bj = j.bibjson()
bj.add_identifier(bj.P_ISSN, "1234-5678")
j.set_in_doaj(True)
j.save()
asource = AccountFixtureFactory.make_publisher_source()
account = models.Account(**asource)
account.set_id("testowner")
account.save()
# push an article to initialise the mappings
source = ArticleFixtureFactory.make_article_source()
article = models.Article(**source)
article.save(blocking=True)
article.delete()
models.Article.blockdeleted(article.id)
handle = Crossref442ArticleFixtureFactory.upload_1_issn_correct()
f = FileMockFactory(stream=handle)
previous = []
job = ingestarticles.IngestArticlesBackgroundTask.prepare("testowner", upload_file=f, schema="crossref442",
previous=previous)
id = job.params.get("ingest_articles__file_upload_id")
self.cleanup_ids.append(id)
# because file upload gets created and saved by prepare
time.sleep(1)
task = ingestarticles.IngestArticlesBackgroundTask(job)
task.run()
# because file upload needs to be re-saved
time.sleep(1)
fu = models.FileUpload.pull(id)
assert fu is not None
assert fu.status == "processed"
def test_27_run_exists(self):
etree.XMLSchema = self.mock_load_schema
requests.head = ResponseMockFactory.head_fail
requests.get = ResponseMockFactory.crossref442_get_success
j = models.Journal()
j.set_owner("testowner")
bj = j.bibjson()
bj.add_identifier(bj.P_ISSN, "1234-5678")
j.set_in_doaj(True)
j.save()
asource = AccountFixtureFactory.make_publisher_source()
account = models.Account(**asource)
account.set_id("testowner")
account.save()
# push an article to initialise the mappings
source = ArticleFixtureFactory.make_article_source()
article = models.Article(**source)
article.save(blocking=True)
article.delete()
models.Article.blockdeleted(article.id)
url = "http://valid"
previous = []
job = ingestarticles.IngestArticlesBackgroundTask.prepare("testowner", url=url, schema="crossref442",
previous=previous)
id = job.params.get("ingest_articles__file_upload_id")
self.cleanup_ids.append(id)
# because file upload gets created and saved by prepare
time.sleep(1)
task = ingestarticles.IngestArticlesBackgroundTask(job)
task.run()
# because file upload needs to be re-saved
time.sleep(1)
fu = models.FileUpload.pull(id)
assert fu is not None
assert fu.status == "processed"
def test_29_submit_success(self):
etree.XMLSchema = self.mock_load_schema
j = models.Journal()
j.set_owner("testowner")
bj = j.bibjson()
bj.add_identifier(bj.P_ISSN, "1234-5678")
j.set_in_doaj(True)
j.save()
asource = AccountFixtureFactory.make_publisher_source()
account = models.Account(**asource)
account.set_id("testowner")
account.save()
# push an article to initialise the mappings
source = ArticleFixtureFactory.make_article_source()
article = models.Article(**source)
article.save(blocking=True)
article.delete()
models.Article.blockdeleted(article.id)
handle = Crossref442ArticleFixtureFactory.upload_1_issn_correct()
f = FileMockFactory(stream=handle)
previous = []
job = ingestarticles.IngestArticlesBackgroundTask.prepare("testowner", upload_file=f, schema="crossref442",
previous=previous)
id = job.params.get("ingest_articles__file_upload_id")
self.cleanup_ids.append(id)
# because file upload gets created and saved by prepare
time.sleep(1)
# scheduling does not result in immidiate execution for huey version > 2
# always eager mode is replaced by immediate mode
# in immediate mode scheduled jobs are not executed
task = ingestarticles.IngestArticlesBackgroundTask(job)
task.run()
fu = models.FileUpload.pull(id)
assert fu is not None
assert fu.status == "processed"
def test_31_crossref_run_fail_unmatched_issn(self):
etree.XMLSchema = self.mock_load_schema
j = models.Journal()
j.set_owner("testowner")
bj = j.bibjson()
bj.add_identifier(bj.P_ISSN, "1234-5678")
bj.add_identifier(bj.E_ISSN, "9876-5432")
j.set_in_doaj(True)
j.save(blocking=True)
asource = AccountFixtureFactory.make_publisher_source()
account = models.Account(**asource)
account.set_id("testowner")
account.save(blocking=True)
handle = Crossref442ArticleFixtureFactory.upload_2_issns_ambiguous()
f = FileMockFactory(stream=handle)
job = ingestarticles.IngestArticlesBackgroundTask.prepare("testowner", schema="crossref442", upload_file=f)
id = job.params.get("ingest_articles__file_upload_id")
self.cleanup_ids.append(id)
# because file upload gets created and saved by prepare
time.sleep(1)
task = ingestarticles.IngestArticlesBackgroundTask(job)
task.run()
# because file upload needs to be re-saved
time.sleep(1)
fu = models.FileUpload.pull(id)
assert fu is not None
assert fu.status == "failed"
assert fu.error is not None and fu.error != ""
assert fu.error_details is None
fr = fu.failure_reasons
assert "unmatched" in fr
assert fr["unmatched"] == ["2345-6789"]
def test_32_run_crossref_fail_shared_issn(self):
etree.XMLSchema = self.mock_load_schema
j1 = models.Journal()
j1.set_owner("testowner1")
bj1 = j1.bibjson()
bj1.add_identifier(bj1.P_ISSN, "1234-5678")
bj1.add_identifier(bj1.E_ISSN, "9876-5432")
j1.set_in_doaj(True)
j1.save()
j2 = models.Journal()
j2.set_owner("testowner2")
j2.set_in_doaj(True)
bj2 = j2.bibjson()
bj2.add_identifier(bj2.P_ISSN, "1234-5678")
bj2.add_identifier(bj2.E_ISSN, "9876-5432")
j2.save(blocking=True)
asource = AccountFixtureFactory.make_publisher_source()
account = models.Account(**asource)
account.set_id("testowner1")
account.save(blocking=True)
# crossref
handle = Crossref442ArticleFixtureFactory.upload_2_issns_correct()
f = FileMockFactory(stream=handle)
job = ingestarticles.IngestArticlesBackgroundTask.prepare("testowner1", schema="crossref442", upload_file=f)
id = job.params.get("ingest_articles__file_upload_id")
self.cleanup_ids.append(id)
# because file upload gets created and saved by prepare
time.sleep(1)
task = ingestarticles.IngestArticlesBackgroundTask(job)
task.run()
# because file upload needs to be re-saved
time.sleep(1)
fu = models.FileUpload.pull(id)
assert fu is not None
assert fu.status == "failed"
assert fu.error is not None and fu.error != ""
assert fu.error_details is None
fr = fu.failure_reasons
assert "shared" in fr
assert "1234-5678" in fr["shared"]
assert "9876-5432" in fr["shared"]
def test_33_run_fail_unowned_issn(self):
# Create 2 journals with different owners and one different issn each. The two issns in the
# article match each of the journals respectively
# We expect an ingest failure
etree.XMLSchema = self.mock_load_schema
j1 = models.Journal()
j1.set_owner("testowner1")
bj1 = j1.bibjson()
bj1.add_identifier(bj1.P_ISSN, "1234-5678")
j1.set_in_doaj(True)
j1.save()
j2 = models.Journal()
j2.set_owner("testowner2")
j2.set_in_doaj(True)
bj2 = j2.bibjson()
bj2.add_identifier(bj2.E_ISSN, "9876-5432")
j2.save(blocking=True)
asource = AccountFixtureFactory.make_publisher_source()
account = models.Account(**asource)
account.set_id("testowner")
account.save(blocking=True)
handle = Crossref442ArticleFixtureFactory.upload_2_issns_correct()
f = FileMockFactory(stream=handle)
job = ingestarticles.IngestArticlesBackgroundTask.prepare("testowner", schema="crossref442", upload_file=f)
id = job.params.get("ingest_articles__file_upload_id")
self.cleanup_ids.append(id)
# because file upload gets created and saved by prepare
time.sleep(1)
task = ingestarticles.IngestArticlesBackgroundTask(job)
task.run()
# because file upload needs to be re-saved
time.sleep(1)
fu = models.FileUpload.pull(id)
assert fu is not None
assert fu.status == "failed"
assert fu.error is not None and fu.error != ""
assert fu.error_details is None
fr = fu.failure_reasons
assert "unowned" in fr
assert "9876-5432" in fr["unowned"]