Error in findInterval(x$log_discharge, break_pts) : 'vec' must be sorted non-decreasingly and not contain NAs

[dcallen]

Hi there ... I think I am getting the same issue as this one that was has been closed: #155

I added a comment there yesterday but then thought it might be best to submit as a new issue.

I get the following error message when running calc_timingAverage() with some datafiles but not with others:

Error in findInterval(x$log_discharge, break_pts) : 'vec' must be sorted non-decreasingly and not contain NAs

I've attached a few test files that cause this error. These all have many discharge values < 1, so perhaps it is the same problem from the issue that was closed?

test2.txt
test1.txt
test3.txt

[dblodgett-usgs]

Thanks for the report @dcallen -- I'll look into this tomorrow or next week.

How did you install EflowStats? Want to make sure you have the latest code with that fix in place?

[dcallen]

Awesome, thanks for quick response! I have EflowStats ver 5.0.0 installed. I went though GRAN to install. I just double checked by reinstalling and running the code again, still getting the same issue. One caveat is that we are using GRDC (https://www.bafg.de/GRDC/) and not USGS gage data, which we’ve processed to make similar to USGS gage data (though still in metric units) and northern hemisphere water years. We are running EflowStats on 3188 stations, and this issue happened frequently enough on a test batch (this error in 5 of 22 station datafiles) that we had to take the calc_timingAverage() function out of the loop. I am also getting another error on only 3 of the 3188 stations with the calc_timingHigh() function, error message we get on just those three is "Error: $ operator is invalid for atomic vectors”. I’m still poking around with this one (and it is rare enough that we could calculate the “th" metrics manually on those 3 files), but I’m not sure why we get that error message on a matrix that was generated through the validate_data() function? I can send you those data as well if you want to take a look. My best! Dan Daniel C. Allen, PhD Assistant Professor Department of Biology University of Oklahoma www.allenlab.org<http://www.allenlab.org> On Nov 15, 2018, at 1:56 PM, David Blodgett <notifications@github.com<mailto:notifications@github.com>> wrote: Thanks for the report @dcallen<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_dcallen&d=DwMCaQ&c=qKdtBuuu6dQK9MsRUVJ2DPXW6oayO8fu4TfEHS8sGNk&r=2X2clPziQO01wnnosFVzcg&m=Vw-m4946EAUEEd7JMeupTgyB9OTMPBphB46v1HByhJI&s=Og26kz7fdskdEzTXEsBvStiP1OzzS8mOnglVoRBYeLg&e=> -- I'll look into this tomorrow or next week. How did you install EflowStats? Want to make sure you have the latest code with that fix in place? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_USGS-2DR_EflowStats_issues_161-23issuecomment-2D439187136&d=DwMCaQ&c=qKdtBuuu6dQK9MsRUVJ2DPXW6oayO8fu4TfEHS8sGNk&r=2X2clPziQO01wnnosFVzcg&m=Vw-m4946EAUEEd7JMeupTgyB9OTMPBphB46v1HByhJI&s=3B_9YJDZsa9yALHx8Bvc2s-7Vj-8oBZagQONi3dxx-o&e=>, or mute the thread<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AVazMF0V4spNRtTEoz63ypguEFBaQfjMks5uvdUXgaJpZM4Yg-5Fwy&d=DwMCaQ&c=qKdtBuuu6dQK9MsRUVJ2DPXW6oayO8fu4TfEHS8sGNk&r=2X2clPziQO01wnnosFVzcg&m=Vw-m4946EAUEEd7JMeupTgyB9OTMPBphB46v1HByhJI&s=B7TrLfPDQOFOAxF5KAflFheXmpcRZj3jy7mrB0i2OcA&e=>.

[dblodgett-usgs]

Can you try:
devtools::install_github("USGS-R/EflowStats") ? I'm not 100% sure the fix made it to GRAN.

[dcallen]

That worked!! Thanks. Want to look into the calc_timingHigh() issue? I can send you the data from those three stations that cause that error. On Nov 15, 2018, at 2:25 PM, David Blodgett <notifications@github.com<mailto:notifications@github.com>> wrote: Can you try: devtools::install_github("USGS-R/EflowStats") ? I'm not 100% sure the fix made it to GRAN. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_USGS-2DR_EflowStats_issues_161-23issuecomment-2D439195730&d=DwMCaQ&c=qKdtBuuu6dQK9MsRUVJ2DPXW6oayO8fu4TfEHS8sGNk&r=2X2clPziQO01wnnosFVzcg&m=4JNRKeZLRf8WycgCLPMt8BEq0zis41hKgH3pTujuy80&s=VQLvgBrHSsSXM9yjZCa8l55hiUb_Gcv0xZj0l-PvxSg&e=>, or mute the thread<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AVazMKq7bmj9aA7CLPzTqr1ETOYzdCTZks5uvdvigaJpZM4Yg-5Fwy&d=DwMCaQ&c=qKdtBuuu6dQK9MsRUVJ2DPXW6oayO8fu4TfEHS8sGNk&r=2X2clPziQO01wnnosFVzcg&m=4JNRKeZLRf8WycgCLPMt8BEq0zis41hKgH3pTujuy80&s=fAHKPuQ_RUvLzr-QKVZzgcSfAKBPHpK5fraOt1q-zuY&e=>.

[dblodgett-usgs]

Sure. Send the files along. -- you can zip and post to an issue directly on github if you like.