Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all unnecessary code from aggregateSolute #220

Open
aappling-usgs opened this issue Aug 17, 2017 · 0 comments
Open

Remove all unnecessary code from aggregateSolute #220

aappling-usgs opened this issue Aug 17, 2017 · 0 comments

Comments

@aappling-usgs
Copy link
Contributor

Issue #199 and PR #219 are converting aggregateSolute to an internal function (deprecated for external use) and avoiding using it for uncertainty calculations. This is avoidance is appropriate even if someone doggedly keeps calling it as loadflex:::aggregateSolute, so I think we can take out a ton of the code currently in this function. A minimal function is a maintainable function. Arguments that are no longer necessary can be removed, leaving in a ... argument, then checking ... for named arguments that have been removed and giving an informative warning about them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant