Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom fields not populated if source fields not explicitly requested #379

Closed
Roel opened this issue Mar 14, 2023 · 0 comments · Fixed by #380
Closed

Custom fields not populated if source fields not explicitly requested #379

Roel opened this issue Mar 14, 2023 · 0 comments · Fixed by #380
Assignees
Labels
Milestone

Comments

@Roel
Copy link
Member

Roel commented Mar 14, 2023

  • PyDOV version: master
  • Python version: 3.10
  • Operating System: Ubuntu

Description

The custom fields pkey_boring and pkey_sondering in the interpretaties types are not populated if their source fields Type_proef and Proeffiche are not explicitly requested in the query too.

What I Did

from pydov.search.interpretaties import InformeleStratigrafieSearch

s = InformeleStratigrafieSearch()
df = s.search(max_features=1, return_fields=[
              'pkey_interpretatie', 'pkey_boring', 'pkey_sondering'])

print(df.iloc[0].transpose())
[000/001] .
pkey_interpretatie    https://www.dov.vlaanderen.be/data/interpretat...
pkey_boring                                                         NaN
pkey_sondering                                                      NaN
Name: 0, dtype: object

We expect either pkey_boring or pkey_sondering to be filled in.

@Roel Roel added the bug label Mar 14, 2023
@Roel Roel added this to the v3.0.0 milestone Mar 14, 2023
@Roel Roel self-assigned this Mar 14, 2023
@Roel Roel mentioned this issue Mar 23, 2023
5 tasks
@Roel Roel closed this as completed in #380 Mar 28, 2023
@Roel Roel mentioned this issue Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant