Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't calculate default margin of heading tags #3

Closed
HelloTalib opened this issue Jan 30, 2022 · 7 comments
Closed

Doesn't calculate default margin of heading tags #3

HelloTalib opened this issue Jan 30, 2022 · 7 comments

Comments

@HelloTalib
Copy link

HelloTalib commented Jan 30, 2022

Hi there!,
Thanks for this awesome plugin. I have found a issue on your plugin. when I wrapped content by any kind of html tags your plugin doesn't calculate default margin. that's why this plugin doesn't match with proper height of the content . Is there any solution?
Issue: https://prnt.sc/26lu2ya
Regards.
Abu Talib

@DSekon
Copy link
Owner

DSekon commented Jan 30, 2022

Hi there!, Thanks for this awesome plugin. I have found a issue on your plugin. when I wrapped content by any kind of html tags your plugin doesn't calculate default margin. that's why this plugin doesn't match with proper height of the content . Is there any solution? Issue: https://prnt.sc/26lu2ya Regards. Abu Talib

Hi, Thank you. I'm very pleased that you liked the plugin.
image
The plugin was made more for text and inline tags inside. For what purpose do you need indented inside?

@DSekon
Copy link
Owner

DSekon commented Jan 30, 2022

Although it is possible for two p tags in a row to be indented. There will of course be a problem with line counting.
But a top indent of a first element, it would be better to put it on the container (in my case, div.item) than on the inner element.

@HelloTalib
Copy link
Author

Hi!, I have some dynamic content that's wrapped with all of html tags. that's why, I need to wrapped this content text with tags. It's not possible to add "dreadmore" class in my content text.
https://prnt.sc/26lvlnn

@DSekon
Copy link
Owner

DSekon commented Jan 30, 2022

Hi!, I have some dynamic content that's wrapped with all of html tags. that's why, I need to wrapped this content text with tags. It's not possible to add "dreadmore" class in my content text. https://prnt.sc/26lvlnn

Okay, I hear you. When I release the update, I'll let you know. Probably today or tomorrow.

@HelloTalib
Copy link
Author

HelloTalib commented Jan 30, 2022

Sounds good,
another feature request. It will be awesome, If you try to build this plugin to reduce html tags as much as possible😊

@DSekon
Copy link
Owner

DSekon commented Jan 30, 2022

Sounds good, another feature request. It will be awesome, If you try to build this plugin to use less html tags as much as possible😊

Added version 2.1.0 to github for now. Tomorrow I will add the plugin to npm.
The condition that will use the tag count: only tags must be inside a .drreadmore.
I also reduced the number of tags used.

@HelloTalib
Copy link
Author

Fantastic job! you're doing so far, Thanks for quick response, keep up with the good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants