Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handsontable @babel/polyfill #201

Closed
liuxy0551 opened this issue Sep 2, 2022 · 6 comments
Closed

handsontable @babel/polyfill #201

liuxy0551 opened this issue Sep 2, 2022 · 6 comments
Assignees

Comments

@liuxy0551
Copy link
Collaborator

低版本的 handsontable 引用了 @babel/polyfill,在 Monorepo 架构下会有幽灵依赖的问题,导致单测报错。调研下升级 handsontable。
image

@liuxy0551 liuxy0551 self-assigned this Sep 2, 2022
@mumiao mumiao self-assigned this Sep 21, 2022
@mumiao
Copy link
Collaborator

mumiao commented Sep 21, 2022

handsontable最新版本依赖了 "@babel/polyfill": "^7.8.3", 并没有deprecated掉这个**@babel/polyfill**, Monorepo Pnpm 架构下,只会有packages下面的dependencies
运行时依赖,因此本地跑Unit Cases, 缺失了 @babel/polyfill的包,不是幽灵依赖的问题

@mumiao
Copy link
Collaborator

mumiao commented Sep 21, 2022

@babel编译的包,不打算作为基础包的运行时依赖,解法我再权衡一下

@liuxy0551
Copy link
Collaborator Author

babel/polyfill@7 不再维护,所以考虑升级 handsontable,高版本的 handsontable 不再依赖 babel/polyfill@7

@mumiao
Copy link
Collaborator

mumiao commented Sep 21, 2022

https://github.com/handsontable/handsontable/blob/12.1.2/package.json handsontable最高版本还是依赖了哦

babel/polyfill@7 不再维护,所以考虑升级 handsontable,高版本的 handsontable 不再依赖 babel/polyfill@7

https://github.com/handsontable/handsontable/blob/12.1.2/package.json handsontable最高版本还是依赖了哦

@mumiao
Copy link
Collaborator

mumiao commented Sep 21, 2022

babel/polyfill@7 不再维护,所以考虑升级 handsontable,高版本的 handsontable 不再依赖 babel/polyfill@7

"@handsontable/react 这个包把polyfill废弃了,单元测试报错的是handsontable

@mumiao
Copy link
Collaborator

mumiao commented Sep 26, 2022

@liuxy0551 break changing 放在beta3里面了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants