Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: optimize NotFound #318

Merged
merged 2 commits into from
Apr 23, 2023
Merged

feat: optimize NotFound #318

merged 2 commits into from
Apr 23, 2023

Conversation

liuxy0551
Copy link
Collaborator

简介

  • 使用函数重写
  • 不使用内联样式，改用 className

Online

https://liuxy0551.github.io/dt-react-component/components/not-found

@kongshan-zhuyu
Copy link
Contributor

+1

@kongshan-zhuyu
Copy link
Contributor

文档建议优化成该结构
image

@liuxy0551 liuxy0551 self-assigned this Apr 23, 2023
@liuxy0551 liuxy0551 added the refactor This will improved code readability and reduced complexity label Apr 23, 2023
@liuxy0551 liuxy0551 added this to the Next Version(4.0.0） milestone Apr 23, 2023
@kongshan-zhuyu kongshan-zhuyu merged commit a6b032d into DTStack:feat_v4 Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kongshan-zhuyu kongshan-zhuyu Awaiting requested review from kongshan-zhuyu

@mumiao mumiao Awaiting requested review from mumiao

Assignees

@liuxy0551 liuxy0551

Labels
refactor This will improved code readability and reduced complexity
Projects
None yet
Milestone
Next Version(4.0.0）
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@liuxy0551 @kongshan-zhuyu