Better nick handling in 'repall'

[Tenzer]

I wrote this reply by using the repall command, and as you can see it mentioned myself first. I had a look at the code behind it and made a few improvements:

1. Make sure the person who wrote the tweet we are replying to is mentioned first (unless it's the RS user).
2. Make sure we don't mention the RS user.
3. Make sure the same user isn't mentioned multiple times.

I also switched the previous nick parsing to use the entities list of the tweet. Here's a link to the documentation for that.

[Tenzer]

Thinking about it, there's only one case where these changes won't "do the right thing", that is if you use repall on your own tweet where you don't mention anybody else. In that case the tweet would be prefixed with the white space which is inserted between the list of nicks (which would be empty) and the message.

Perhaps it would be better to move the filtering of the user's own nick into the for-loop, so the person you are responding to always will be mentioned first in the reply, regardless of it being yourself or not. What do you think?

[orakaro]

Hi @Tenzer Thanks for contributing 👍 I can see why this should be improved, but how to fix is really hard. Can you show me how to move the filter ?

[Tenzer]

Sure, I have done it in commit 97def8f. I copied the code styling used in trend() in order to avoid having a too long line with the if. If you have any comments for this, let me know.

[orakaro]

Thanks !! I will test this for a while before merge

[Tenzer]

I'll do the same. If it turns out to work fine, I think it would make sense to look through the code and see if there are other places where it could benefit from using entities instead of parsing items from the tweet text.

[Tenzer]

I just pushed an extra commit to the branch, it corrects a mistake I made where I try to iterate over the tweet module instead of the original_tweet variable, so it didn't work before.