Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matrix Dimension Problem #1

Open
adodge opened this issue Aug 29, 2018 · 3 comments
Open

Matrix Dimension Problem #1

adodge opened this issue Aug 29, 2018 · 3 comments

Comments

@adodge
Copy link

adodge commented Aug 29, 2018

Hiya! Thank you for writing this up. I'm finding it interesting to play with.

I'm running into some issues that seem to be related to the "stability fix" in cca_layer.py. When we drop the components with small eigenvalues, it causes problems when we later assume these matrices are square and, also, when we try to multiply them with SigmaHat12 (which doesn't have its shape updated).

I've created a patch, and I'll submit a pull request for you to look at. The change I'm proposing seems to fix some occasional crashes, but I'm not familiar enough with the underlying math to be sure that I haven't screwed up the semantics of what the code is trying to accomplish.

Thanks,
Alex Dodge

@adodge
Copy link
Author

adodge commented Sep 4, 2018

#4

@salarjf
Copy link

salarjf commented Oct 1, 2018

Hello. First of all thanks for sharing your code. Personally I was looking for tf implementation of dcca and yours is the only one.

I am currently trying to use your code on acoustic features and I encounter with the following error:

LinAlgError: Eigenvalues did not converge
on this line:
return np.linalg.eigh(x)

I guess there is a semantic issue that causes this error. I'd appreciate if you could share with me any hint of yours about the solution.
Many Thanks
Salar Jafarlou

@adodge
Copy link
Author

adodge commented Oct 1, 2018

What version of numpy are you using? I believe I experienced this problem with 1.13.1, but not with 1.15.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants