Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dfo_gen is relying on dataflowapp.source_id, which is not in schema #196

Open
eflumerf opened this issue Sep 16, 2022 · 1 comment
Open

Comments

@eflumerf
Copy link
Member

dfo_gen needs the SourceID and token_count from each dataflow app. Before, the dataflow app configs were dicts, and daqconf_multiru_gen simply added a "source_id" member to that dict using the SourceIDBroker. Now that the dataflow app configs are schema dataflowapp objects, this is a potentially undefined operation. I have verified that appropriate configurations are still generated, but we need to re-think the logic here to make sure that we aren't relying on this kind of behavior.

@eflumerf
Copy link
Member Author

Probably the resolution will involve restructuring the data sent to dfo_gen, but we don't want to do that right now because of other ongoing development (since it works for now).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant