Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full Config Is Faulty #446

Open
aeoranday opened this issue Mar 28, 2024 · 0 comments
Open

Full Config Is Faulty #446

aeoranday opened this issue Mar 28, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@aeoranday
Copy link
Member

While trying to use fddaqconf_gen on config/daqconf_full_config.json, I came across various parameters that were not updated or were removed. This includes:

The removed parameters appear intentional at first glance and that the change was not propagated to daqconf_full_config.json. However, I'm not familiar with those systems, so someone who is familiar should comment.

The TA & TC config format change looks like a failed extension and mlt_roi_conf bracket appears like a mistake.

This was tested using the instructions here where the example daqconf.json is replaced with config/daqconf_full_config.json. fddaqconf_gen would fail before recognizing these faults and pass after correcting them.

@aeoranday aeoranday added the bug Something isn't working label Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants