You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While trying to use fddaqconf_gen on config/daqconf_full_config.json, I came across various parameters that were not updated or were removed. This includes:
The removed parameters appear intentional at first glance and that the change was not propagated to daqconf_full_config.json. However, I'm not familiar with those systems, so someone who is familiar should comment.
The TA & TC config format change looks like a failed extension and mlt_roi_conf bracket appears like a mistake.
This was tested using the instructions here where the example daqconf.json is replaced with config/daqconf_full_config.json. fddaqconf_gen would fail before recognizing these faults and pass after correcting them.
The text was updated successfully, but these errors were encountered:
While trying to use
fddaqconf_gen
onconfig/daqconf_full_config.json
, I came across various parameters that were not updated or were removed. This includes:k8s_rte
: Removed in Get rid of the entrypoint #373.dpdk_sender
: Removed in Reorganize daqconf schema options #354.dpdk_rxqueues_per_lcore
: Removed in DAQ conf Split #386.thread_pinning_file
: Removed in DAQ conf Split #386.trigger_rate_hz
: Removed in Reorganize daqconf schema options #354.trigger_activity_config
(and similar) : Should now be a list format instead of singular. Changed in Concurrent triggering algorithms #394.mlt_roi_conf
: Doesn't properly close brackets from changes related to ROI random selection in MLT #398.The removed parameters appear intentional at first glance and that the change was not propagated to
daqconf_full_config.json
. However, I'm not familiar with those systems, so someone who is familiar should comment.The TA & TC config format change looks like a failed extension and
mlt_roi_conf
bracket appears like a mistake.This was tested using the instructions here where the example
daqconf.json
is replaced withconfig/daqconf_full_config.json
.fddaqconf_gen
would fail before recognizing these faults and pass after correcting them.The text was updated successfully, but these errors were encountered: