Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better name for static method #29

Open
mroda88 opened this issue Mar 27, 2023 · 2 comments
Open

better name for static method #29

mroda88 opened this issue Mar 27, 2023 · 2 comments
Assignees
@mroda88
Labels
documentation Improvements or additions to documentation

Comments

@mroda88
Copy link
Contributor

mroda88 commented Mar 27, 2023

After the new changes, we introduce a static method called _get_inheritance().
We might want to think about a better name.
@mroda88 mroda88 added the documentation Improvements or additions to documentation label Mar 27, 2023
@mroda88 mroda88 self-assigned this Mar 27, 2023
@bieryAtFnal
Copy link
Contributor

I'm guessing that this is for v4.1.0, so I set that Target Release value in this Issue. Please correct the value if not.

@mroda88
Copy link
Contributor Author

mroda88 commented Mar 28, 2023

You are absolutely correct! Probably even for after 4.1.0. That's why at the beginning I didn't even put it in the DUNE-DAQ tracking. Leave it there if you think it's useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mroda88 mroda88

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mroda88 @bieryAtFnal