Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could locally defined timestamp_t in readout code be replaced with daqdataformats::timestamp_t? #83

Open
bieryAtFnal opened this issue Mar 3, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@bieryAtFnal
Copy link
Contributor

I noticed that several of our FrameProcessor, etc. files use a locally declared "using" statement to define a local timestamp_t data type rather than using daqdataformats::timestamp_t.

Could this be changed so that we don't have multiple definitions of timestamp_t?

./ssp/SSPFrameProcessor.hpp:  using timestamp_t = std::uint64_t; // NOLINT(build/unsigned)
./wibeth/WIBEthFrameProcessor.hpp:  using timestamp_t = std::uint64_t; // NOLINT(build/unsigned)
./daphne/DAPHNEStreamFrameProcessor.hpp:  using timestamp_t = std::uint64_t; // NOLINT(build/unsigned)
./daphne/DAPHNEFrameProcessor.hpp:  using timestamp_t = std::uint64_t; // NOLINT(build/unsigned)
./wib/SWWIBTriggerPrimitiveProcessor.hpp:  using timestamp_t = std::uint64_t; // NOLINT(build/unsigned)
./wib/WIBFrameProcessor.hpp:  using timestamp_t = std::uint64_t; // NOLINT(build/unsigned)
./wib2/WIB2FrameProcessor.hpp:  using timestamp_t = std::uint64_t; // NOLINT(build/unsigned)
./wib2/SWWIBTriggerPrimitiveProcessor.hpp:  using timestamp_t = std::uint64_t; // NOLINT(build/unsigned)
./wib2/RAWWIBTriggerPrimitiveProcessor.hpp:  using timestamp_t = std::uint64_t; // NOLINT(build/unsigned)
./tde/TDEFrameProcessor.hpp:  using timestamp_t = std::uint64_t; // NOLINT(build/unsigned)
@roland-sipos roland-sipos self-assigned this Apr 26, 2023
@roland-sipos roland-sipos added the enhancement New feature or request label Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants