Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy Up: get_trigger_app() #215

Open
CharlieBatchelor opened this issue Apr 13, 2023 · 0 comments
Open

Tidy Up: get_trigger_app() #215

CharlieBatchelor opened this issue Apr 13, 2023 · 0 comments
Labels
maintenance Addresses user request or change in another part of the system

Comments

@CharlieBatchelor
Copy link
Contributor

As mentioned in #202:

get_trigger_app() Tidy Up

The configuration generation for trigger is quite messy, and should be tidied up. It essentially does two things:

  1. For a given tp_config item passed to the function, it generates a list of Modules. For example, it does things like "For each link, create a TPChannelFilter module, TPBuffer module..." and so on.
  2. It then connects up all the modules in the list according to what we expect/want the system to run like.

Each step is itself done in quite a convoluted order, and it would make it more readable to generate the configuration in a "top to bottom" sense, based on the trigger flow graph diagrams, at least IMO. Start with the channel filters, to TPSetTees, to heartbeats and buffers, and so on.

@CharlieBatchelor CharlieBatchelor added the maintenance Addresses user request or change in another part of the system label Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Addresses user request or change in another part of the system
Projects
None yet
Development

No branches or pull requests

1 participant