Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use moo schema for algorithm configuration parameters. #15

Open
BenLand100 opened this issue Jun 18, 2021 · 1 comment
Open

Use moo schema for algorithm configuration parameters. #15

BenLand100 opened this issue Jun 18, 2021 · 1 comment

Comments

@BenLand100
Copy link
Collaborator

Currently the configure methods for Trigger*Maker accept raw nlohmann::json objects containing their configurations, and anything using these must create the correct structure to configure the algorithm. It would be better if these algorithms could define a schema for their configuration using moo, similar to DUNE DAQModules. This needs to be done such that no dependency on daq-cmake is introduced, so triggeralgs can still be built and used outside of a daq software environment.

@brettviren
Copy link
Member

A very good idea.

To avoid dependency on daq-cmake I think here is one case where committing the generated files to a repo is okay. Because moo codegen is idempotent, the generated header files will only change when the developer actually modifies their schema (no repo bloat for inconsequential changes). This will not only erase daq-cmake as a build-time dependency but moo itself will not be needed to build the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants