Update event hierarchy #1952
Merged
Update event hierarchy #1952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MinnDevelopment
added
the
status: documentation needed
MinnDevelopment
added
the
type: breaking
src/main/java/net/dv8tion/jda/api/events/session/GenericSessionEvent.java
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/api/events/session/GenericSessionEvent.java
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/api/events/session/SessionRecreateEvent.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/api/events/session/SessionDisconnectEvent.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/api/events/guild/GuildReadyEvent.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/api/events/session/SessionInvalidateEvent.java
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/api/events/session/SessionResumedEvent.java
Outdated
Show resolved
Hide resolved
…tion # Conflicts: # src/main/java/net/dv8tion/jda/api/JDABuilder.java # src/main/java/net/dv8tion/jda/api/events/guild/voice/GenericGuildVoiceUpdateEvent.java # src/main/java/net/dv8tion/jda/api/events/guild/voice/GuildVoiceJoinEvent.java # src/main/java/net/dv8tion/jda/api/events/guild/voice/GuildVoiceLeaveEvent.java # src/main/java/net/dv8tion/jda/api/events/guild/voice/GuildVoiceMoveEvent.java # src/main/java/net/dv8tion/jda/api/events/guild/voice/GuildVoiceUpdateEvent.java # src/main/java/net/dv8tion/jda/api/hooks/ListenerAdapter.java # src/main/java/net/dv8tion/jda/internal/requests/WebSocketClient.java
MinnDevelopment
added
type: enhancement
and removed
status: documentation needed
DV8FromTheWorld
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Etiquette
Changes
Closes Issue: NaN
Description
This addresses the simplifying events plan. However, there is still room to discuss these changes, especially renaming of events can be viewed critically.
The removal of the voice events is inspired by the common misconceptions of the
GuildVoiceLeaveEventwhich did not include voice moves. I think splitting these events up is confusing and unnecessarily complicated, which is why I'm proposing to merge them into a single event.