Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle text in voice channels #2072

Merged
merged 28 commits into from Jul 10, 2022
Merged

Handle text in voice channels #2072

merged 28 commits into from Jul 10, 2022

Conversation

MinnDevelopment
Copy link
Member

@MinnDevelopment MinnDevelopment commented Mar 27, 2022 •
edited

Pull Request Etiquette

Changes

  • Internal code
  • Library interface (affecting end-user code)
  • Documentation
  • Other: _____

Closes Issue: NaN

Description

This adds the required changes to handle messages in voice channels. Undocumented information:

  • VoiceChannels cannot have threads and cannot be system/community channels
  • VoiceChannels can have webhooks
  • How the CONNECT permission influences this is not entirely clear yet (and entirely undocumented)

TODO: We need to handle webhooks for voice channels since BaseGuildMessageChannel combines webhooks and threads, however threads aren't supported.

Not supported by discord:

  • You can't set a slowmode for voice channels
  • You can't create threads for voice channels

@Xirado Xirado mentioned this pull request Mar 27, 2022
Closed
6 tasks
@MinnDevelopment MinnDevelopment changed the title Start work on text in voice channels Handle text in voice channels Mar 27, 2022
@MinnDevelopment MinnDevelopment mentioned this pull request Apr 3, 2022
Merged
6 tasks
@MinnDevelopment MinnDevelopment added the type: breaking contains a backwards incompatible change label Apr 13, 2022
@MinnDevelopment
Merge remote-tracking branch 'origin/master' into feature/text-in-voice
b0ba362 
# Conflicts:
#	src/main/java/net/dv8tion/jda/internal/handle/MessageBulkDeleteHandler.java
#	src/main/java/net/dv8tion/jda/internal/handle/MessageCreateHandler.java
#	src/main/java/net/dv8tion/jda/internal/handle/MessageDeleteHandler.java
#	src/main/java/net/dv8tion/jda/internal/handle/MessageReactionBulkRemoveHandler.java
#	src/main/java/net/dv8tion/jda/internal/handle/MessageReactionClearEmoteHandler.java
#	src/main/java/net/dv8tion/jda/internal/handle/MessageReactionHandler.java
#	src/main/java/net/dv8tion/jda/internal/handle/MessageUpdateHandler.java
#	src/main/java/net/dv8tion/jda/internal/handle/TypingStartHandler.java
@HagarJNode

This comment was marked as resolved.

Sign in to view
@MinnDevelopment

This comment was marked as resolved.

Sign in to view
@HagarJNode

This comment was marked as resolved.

Sign in to view
@MoonTM-GIT MoonTM-GIT mentioned this pull request Jun 17, 2022
Merged
@MinnDevelopment
Update permission check
4dfdd74
@MinnDevelopment
Merge remote-tracking branch 'origin/master' into feature/text-in-voice
ff56052 
# Conflicts:
#	src/main/java/net/dv8tion/jda/api/entities/IWebhookContainer.java
#	src/main/java/net/dv8tion/jda/api/entities/Message.java
#	src/main/java/net/dv8tion/jda/api/entities/MessageReaction.java
#	src/main/java/net/dv8tion/jda/api/entities/VoiceChannel.java
#	src/main/java/net/dv8tion/jda/api/events/message/GenericMessageEvent.java
#	src/main/java/net/dv8tion/jda/api/events/user/UserTypingEvent.java
#	src/main/java/net/dv8tion/jda/internal/entities/AbstractMessage.java
#	src/main/java/net/dv8tion/jda/internal/entities/EntityBuilder.java
#	src/main/java/net/dv8tion/jda/internal/entities/ReceivedMessage.java
#	src/main/java/net/dv8tion/jda/internal/entities/VoiceChannelImpl.java
@MinnDevelopment
Update some more permission checks
4dc7258
@MinnDevelopment MinnDevelopment marked this pull request as ready for review July 3, 2022 17:40
@MinnDevelopment MinnDevelopment added this to Review in progress in v5 Jul 4, 2022
DV8FromTheWorld
DV8FromTheWorld reviewed Jul 7, 2022
View reviewed changes
Copy link
Member

@DV8FromTheWorld DV8FromTheWorld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review. Will review more later

src/main/java/net/dv8tion/jda/api/entities/MessageHistory.java Outdated Show resolved Hide resolved
src/main/java/net/dv8tion/jda/api/entities/MessageHistory.java Outdated Show resolved Hide resolved
src/main/java/net/dv8tion/jda/api/entities/MessageReference.java Outdated Show resolved Hide resolved
src/main/java/net/dv8tion/jda/api/entities/channel/IAgeRestrictedChannel.java Outdated Show resolved Hide resolved
src/main/java/net/dv8tion/jda/api/entities/channel/unions/GuildMessageChannelUnion.java Outdated Show resolved Hide resolved
src/main/java/net/dv8tion/jda/internal/entities/ReceivedMessage.java Outdated Show resolved Hide resolved
src/main/java/net/dv8tion/jda/internal/entities/VoiceChannelImpl.java Outdated Show resolved Hide resolved
v5 automation moved this from Review in progress to Reviewer approved Jul 9, 2022
@MinnDevelopment MinnDevelopment merged commit 07e8166 into master Jul 10, 2022
v5 automation moved this from Reviewer approved to Done Jul 10, 2022
@MinnDevelopment MinnDevelopment deleted the feature/text-in-voice branch July 10, 2022 12:17
@TheNitesWhoSay
Copy link

Eagerly awaiting a release on voice-text support when you are able - spam bots have began using the voice-text channels.

@freya022
Copy link
Contributor

You can use jitpack to use pre releases
See https://jda.wiki/using-jda/using-new-features/#using-jitpack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DV8FromTheWorld DV8FromTheWorld DV8FromTheWorld approved these changes

Assignees
No one assigned
Labels
type: breaking contains a backwards incompatible change
Projects
v5
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@MinnDevelopment @HagarJNode @TheNitesWhoSay @freya022 @DV8FromTheWorld