Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requried a minimum amount of REP to vote in favor of executing boosted proposals #43

Closed
AugustoL opened this issue Apr 21, 2021 · 0 comments
Assignees
Projects
Milestone

Comments

@AugustoL
Copy link
Member

Problem
The genesis protocol machine that we are using allows any the execution of any boosted proposal with any amount of positive votes, this means that if a boosted proposal reach the execution time with 1 REP it will be executed. We have been talking about this and we considered this a problem, we need to be able to set up a mimum amount of positive votes required for a proposal to be executed.

Solution
Modify the configuration parameter in the voting machine contract called queuedVoteRequiredPercentage to be an array of uints, having in the first index the queuedVoteRequiredPercentage and in the second index the boostedVoteRequiredPercentage.

Every time a boosted proposal will be executed the amount of % in prositive votes needs to be higher than boostedVoteRequiredPercentage

Additional context
DXDVotingMachine contract: https://github.com/AugustoL/dxdao-contracts/blob/dxdao-contracts/contracts/dxdao/DXDVotingMachine.sol

@AugustoL AugustoL added this to the v1.0 milestone Apr 21, 2021
@AugustoL AugustoL self-assigned this Apr 21, 2021
@AugustoL AugustoL added this to To do in DXvote v1.0 Apr 21, 2021
@AugustoL AugustoL changed the title Requries a minimum amount of REP to vote in favor of executing boosted proposals Requried a minimum amount of REP to vote in favor of executing boosted proposals Apr 21, 2021
@AugustoL AugustoL moved this from To do to In progress in DXvote v1.0 Aug 20, 2021
@AugustoL AugustoL moved this from In progress to Done in DXvote v1.0 Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
DXvote v1.0
  
Done
Development

No branches or pull requests

1 participant