Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summary of actions in proposal card #805

Closed
rossneilson opened this issue Apr 21, 2022 · 1 comment
Closed

Summary of actions in proposal card #805

rossneilson opened this issue Apr 21, 2022 · 1 comment
Assignees
Labels
Milestone

Comments

@rossneilson
Copy link
Collaborator

rossneilson commented Apr 21, 2022

One of the last placeholders we have is showing all proposals transferring 150 ETH to Gero, time to fix that.
With the action builder mostly complete we can now easily decode proposal actions.

We obviously cant show all of the actions when we can have huge numbers of actions and options for each proposal so we need some logic to prioritise the most important calls. In future we'll have a proper importance ranking but for now the below logic can work to order them.

  1. REP minting is always most important
    eg Mint 1% REP -> rossdev.eth
  2. ENS contract interaction
    eg (ENS icon) dxvote.eth
  3. Spending calls (Approval + function call grouped together, same to address)
    eg 1000 DAI -> Swap
  4. Transfers
    eg 1000 DAI -> rossdev.eth
  5. Generic calls
    eg Swap (taken from rich contract function name)

We should ideally show 2-3 actions but would be good to show as many as we can fit, maybe a fixed size that just cuts off after it wont fit?

@rossneilson rossneilson added the Enhancement New feature or request label Apr 21, 2022
@rossneilson rossneilson modified the milestones: v1.1-1, v1.1-2 Apr 21, 2022
@rossneilson
Copy link
Collaborator Author

We should also have another layer of ordering ontop of the ones described above which shows proposal actions winning and past quorum first as these are most relevant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

3 participants