Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to new Image Entity #33

Closed
stboch opened this issue Jul 11, 2023 · 2 comments
Closed

Migrate to new Image Entity #33

stboch opened this issue Jul 11, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request Stale

Comments

@stboch
Copy link

stboch commented Jul 11, 2023

Is your feature request related to a problem? Please describe.
Home-Assistant 2023.7 added support for Image Entity...
https://www.home-assistant.io/blog/2023/07/05/release-20237/#image-entities

Describe the solution you'd like
Migrate from Camera entity to image entitty. Hopefully this will reduce complexity and allow for new cooler features going forward.

@Daanoz Daanoz self-assigned this Jul 11, 2023
@Daanoz Daanoz added the enhancement New feature or request label Jul 11, 2023
@Daanoz
Copy link
Owner

Daanoz commented Jul 11, 2023

I looked into this, the main issue here is that the call to retrieve the image is not provided with the contextual dimensions. This would basically force the integration to always give back the highest resolution image without any cropping possibilities. Also if I every get to implementing the retrieval of videos, this would probably not work with the image entity.

All in all, only downsides at the moment, but willing to revisit this once there is a nice use case.

@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Aug 11, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Stale
Projects
None yet
Development

No branches or pull requests

2 participants