Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict with polymerfire firebase messaging on-message event #3

Closed
fredmanders opened this issue Nov 21, 2017 · 1 comment
Closed

Comments

@fredmanders
Copy link

I have the firebase-messaging element from polymerfire and the share-menu element in the same element in my app. When I receive a Firebase Cloud message on the foreground, the on-message event is fired. I think the widgets.js from Twitter also intercepts this event, resulting in this error:

Uncaught TypeError: Cannot read property 'twttr.button' of undefined at o (widgets.js:formatted:4740) at s._onMessage (widgets.js:formatted:4772) at widgets.js:formatted:694 at HTMLElement.fire (legacy-element-mixin.html:372) at firebase-messaging.html:114 at Array.forEach (<anonymous>) at Object.next (firebase-messaging.html:112) at firebase-app.js:3453 at firebase-app.js:3453 at <anonymous> o @ widgets.js:formatted:4740 _onMessage @ widgets.js:formatted:4772 (anonymous) @ widgets.js:formatted:694 fire @ legacy-element-mixin.html:372 (anonymous) @ firebase-messaging.html:114 (anonymous) @ firebase-messaging.html:112 (anonymous) @ firebase-app.js:3453 (anonymous) @ firebase-app.js:3453 Promise resolved (async) e.sendOne @ firebase-app.js:3453 e.forEachObserver @ firebase-app.js:3453 e.next @ firebase-app.js:3453 (anonymous) @ firebase-messaging.js:1618

Is there a way to fix this without changing the code in the bower_components folder?

@Dabolus
Copy link
Owner

Dabolus commented Oct 17, 2018

In the latest version, Twitter widget is not included anymore, so everything should work fine.

@Dabolus Dabolus closed this as completed Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants