Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle HTTP Errors on font file references #25

Open
nickfujita opened this issue Apr 3, 2018 · 1 comment
Open

Gracefully handle HTTP Errors on font file references #25

nickfujita opened this issue Apr 3, 2018 · 1 comment

Comments

@nickfujita
Copy link
Contributor

When providing a reference to a font file as a part of options, it was find that in the case where for some reason there was an error retrieving said file, the library errors out. Rather than having this prevent the subs from rendering at all, would it be possible to instead handle this gracefully, by not erroring out, and just render any subs with the default library font?

@nickfujita
Copy link
Contributor Author

Just wanted to ping for any feedback. I've been trying over and over to get this repo compiling on my local machine (OSX) but always receiving errors when patching. As detailed here

@TFSThiagoBR98 TFSThiagoBR98 changed the title Gracefully handle 40x on font file references Gracefully handle HTTP Errors on font file references Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants