Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap variables still get included #496

Closed
werm opened this issue Aug 28, 2014 · 3 comments · Fixed by #497
Closed

Bootstrap variables still get included #496

werm opened this issue Aug 28, 2014 · 3 comments · Fixed by #497
Labels

Comments

@werm
Copy link

werm commented Aug 28, 2014

If you run the generator and choose Sass and no Bootstrap, the modal component's scss has Bootstrap variables in it ($brand-primary, $brand-info, etc.)

I'd submit a pull request, but I'm not too familiar with the inner workings of Yeoman.

Steps taken...

[?] What would you like to write scripts with? JavaScript
[?] What would you like to write markup with? HTML
[?] What would you like to write stylesheets with? Sass
[?] What Angular router would you like to use? uiRouter
[?] Would you like to include Bootstrap? No

# Server

[?] Would you like to use mongoDB with Mongoose for data modeling? Yes
[?] Would you scaffold out an authentication boilerplate? Yes
[?] Would you like to include additional oAuth strategies?
[?] Would you like to use socket.io? Yes
@kingcody
Copy link
Member

So you are saying that there is a client/components/modal folder in your generated project ? and that is not expected behavior. I'll see what i can do about that for the future.

In the mean time you can just delete the modal folder, as it was not supposed to be generated when you did not select bootstrap.

@DaftMonk
Copy link
Member

@kingcody Were you able to reproduce the issue? When I say no to bootstrap, I don't get the modal service, or any of the related styles

@kingcody
Copy link
Member

I was. I started with a completely new dir and mirrored @werm's choices. The modal folder was generated with the appropriate files according to the selected prompts, other than it should not have been generated. I used master for the generator branch.

kingcody added a commit to kingcody/generator-angular-fullstack that referenced this issue Aug 29, 2014
Changes:
- `filters.bootstrap` and `filters.uibootstrap` will be true or false only

Closes angular-fullstack#496
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants