Todo list #1
Todo list #1
Conversation
There was a problem hiding this comment.
Hi @Dagic-zewdu ,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
You have submitted a project, that has NO Linter setup. Please ensure that Linter is set up correctly for this repository.
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Invalid Code Review Request does not count into the code reviews limit.
There was a problem hiding this comment.
🔥 Status: Approved 🟢
Hi @Dagic-zewdu 👋🏻,
You have done a great job structuring and going beyond the requirements of the ToDo project in this milestone 💪🏻!
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
To Highlight 💪🏻
✅ No linter errors.
✅ You used correct Github Flow.
✅ Professional README.
✅ Used webpack to bundle JavaScript.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| name: Linters | ||
|
|
||
| on: pull_request | ||
|
|
||
| env: | ||
| FORCE_COLOR: 1 | ||
|
|
||
| jobs: |
There was a problem hiding this comment.
- [OPTIONAL] This linters file is meant to be added to the root of the project. Please kindly move it there because it is meant to apply to all files in the project
| { | ||
| "extends": ["stylelint-config-standard"], | ||
| "plugins": ["stylelint-scss", "stylelint-csstree-validator"], | ||
| "rules": { | ||
| "at-rule-no-unknown": null, | ||
| "scss/at-rule-no-unknown": true, | ||
| "csstree/validator": true | ||
| }, | ||
| "ignoreFiles": ["build/**", "dist/**", "**/reset*.css", "**/bootstrap*.css"] |
There was a problem hiding this comment.
- [OPTIONAL] Please kindly move this linter file to the root of the project.
In this milestone, I added