Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some question about 𝐗_𝑡−𝜌𝐗_(𝑡−1) in the code #4

Closed
Lanturewen opened this issue Dec 14, 2021 · 1 comment
Closed

Comments

@Lanturewen
Copy link

Lanturewen commented Dec 14, 2021

Hello!
as the paper said,the input and output should be:
image
but the code in forecasting_runner:
if args.inp_adj: x = torch.cat([avg[None].repeat(bs, 1, 1), x], dim=1) x = x[:, 1:] - rho * x[:, :-1] prd_y = self.model(x) if args.out_adj: prd_y += rho * x[:, -1]
the x[:, -1] under has changed which mean that x[:, -1]=x[:, 1:] - rho * x[:, :-1] instead of x_{t-1}.
Do I misunderstand?

@Daikon-Sun
Copy link
Owner

Hi,
Yes, you are right.
Originally, this part is written in one line; but when I wanted to run the ablation study, I separated the input and output parts and thus caused the bug.
So, fortunately, the main experiments are run without the error, only the ablation study is affected by this bug.
Thanks for pointing the error out!
I will fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants