Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Additional Compat] EMI Support #52

Closed
MrRedstoneToGo opened this issue Mar 14, 2024 · 15 comments
Closed

[Additional Compat] EMI Support #52

MrRedstoneToGo opened this issue Mar 14, 2024 · 15 comments
Assignees
Labels
enhancement New feature or request

Comments

@MrRedstoneToGo
Copy link

Bulk dying (1.7+1.20.1; fabric) is very good way to recolor wool or glass but you have to install JEI alongside EMI o see them. Create Fabric has integration for EMI already. And if you're going to add new recipes with chance, EMI will factor them into the recipe tree instead of just ignoring them.

Thanks

@DakotaPride DakotaPride self-assigned this Mar 14, 2024
@DakotaPride DakotaPride added the enhancement New feature or request label Mar 14, 2024
@DakotaPride
Copy link
Owner

After a good bit and realizing that I was using the wrong Item Viewer class the entire time, I finally managed to get it working. Should be in the next hotfix, I'll make sure to let you know when it releases!
image

@DakotaPride
Copy link
Owner

It should now be available on Modrinth, but Curseforge files are currently waiting for approval!

@MrRedstoneToGo
Copy link
Author

I just noticed that you added the fluid combinations with lava. This was not expected but it's so useful. Thanks for this mod and these quick updates, how do you do that?

@DakotaPride
Copy link
Owner

No problem! I just really enjoy developing my projects, which can lead me to work all day on them and get maybe a little too much done

@MrRedstoneToGo
Copy link
Author

MrRedstoneToGo commented Mar 18, 2024

Hello, there's a little bug left. If you go to the tuff world interaction recipe and click the recipe tree button on the right and want to produce 5 tuff, EMI will tell you that you need 5 liters of lava and and 5 liters of liquefied mastic resin. Please fix this. If you look at the cobble generator recipe on the same tab and hover over water or lava there's an arrow pointing to the right to the fluid. Add that and I am happy. (I'm already, but...)

@DakotaPride
Copy link
Owner

Could you provide screenshots of this issue? I checked myself and they seem normal.

image image image

@MrRedstoneToGo
Copy link
Author

MrRedstoneToGo commented Mar 18, 2024

Adjust the "x1" with the scroll wheel and you'll see...

@DakotaPride
Copy link
Owner

Logically speaking, it seems to work just fine. Though, I understand that this is something minor that could lead to confusion among players. I see that you've brought this to the attention of the Create devs as well, of which I'll probably wait for the issue to be fixed on their end since I used their classes for Create: Garnished EMI integration.
image

@DakotaPride DakotaPride reopened this Mar 18, 2024
@DakotaPride DakotaPride changed the title Please add EMI support for your Bulk ... recipes [Additional Compat] EMI Support Mar 18, 2024
@DakotaPride DakotaPride pinned this issue Mar 18, 2024
@MrRedstoneToGo
Copy link
Author

MrRedstoneToGo commented Mar 18, 2024

How many buckets of Lava or Mastic resin do you need for a Tuff generator? Two, not 10. Compare this to the cobblestone example. The thing with a cobble gen is that you have infinite cobblestone with just two fluid blocks. I mean: No matter how many blocks you need, there should always be 1000 L of liquid. You don't need to farm a ton of slime balls for a ton of tuff, just 9 anyway. Someone could believe this recipe tree and farm a ton of slime balls and realize the work wasn't necessary.

@MrRedstoneToGo
Copy link
Author

MrRedstoneToGo commented Mar 18, 2024

"Logically speaking, it seems to work just fine. Though, I understand that this is something minor that could lead to confusion among players. I see that you've brought this to the attention of the Create devs as well, of which I'll probably wait for the issue to be fixed on their end since I used their classes for Create: Garnished EMI integration."

And what if we do this otherwise? I know you are quicker. And when they copy your code they're quicker too. Don't take this personally.

@DakotaPride
Copy link
Owner

I can see what I can do, but if I end up not being able to fix it, I'll just wait.

@DakotaPride
Copy link
Owner

If I do find a fix, I'll make sure to make a pull request in the Create mod repository as well.

@MrRedstoneToGo
Copy link
Author

Oh, look at EMI's code and search "cobblestone" . There's the way of the developer

@DakotaPride
Copy link
Owner

I think I found a way to fix it, I've made a pull request over on the Create Fabric repository. Fabricators-of-Create/Create#1387

@DakotaPride
Copy link
Owner

[Create: Garnished] Files have been uploaded to Modrinth, Curseforge is waiting for approval!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants