Add conformance to AFire protocol RequestRetrier
#11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I implemented a new class `SpartanRequestRetrier` that conforms to the Alamofire protocol `SpartanRequestRetrier`. I then configured it in `SpartanRequestManager` class. If the request fails due to a server error, the request will be retried in 1 second. My concerns: - I am afraid this can end up becoming endlessly recursive. - We should give the user the option to enable this feature. - Are there more error codes that should be retried?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented a new class
SpartanRequestRetrierthat conforms to the Alamofire protocolSpartanRequestRetrier. I then configured it inSpartanRequestManagerclass. If the request fails due to a server error, the request will be retried in 1 second.My concerns: