Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text field feedback #3

Closed
scottrobertson opened this issue Jan 19, 2021 · 10 comments
Closed

Text field feedback #3

scottrobertson opened this issue Jan 19, 2021 · 10 comments
Labels
enhancement New feature or request

Comments

@scottrobertson
Copy link
Contributor

scottrobertson commented Jan 19, 2021

Hey

First of all, really like the app. Took me a while to find something like it.

Just a few things about the text field at the top of the menu bar app. Could it be:

  1. Made bigger (it feels kinda "un native" in a way).
  2. Have the focus border removed
  3. Have the text area the whole text field (without the padding around the text field inside it)

Screenshot 2021-01-19 at 13 40 51@2x

And also, perhaps when i open the menu bar app, it auto focuses on the text field, so i can just start typing.

I guess like the Search in the Apple Reminders app:

Screenshot 2021-01-19 at 15 35 16@2x

Screenshot 2021-01-19 at 15 35 21@2x

@DamascenoRafael DamascenoRafael added the enhancement New feature or request label Jan 20, 2021
@DamascenoRafael
Copy link
Owner

DamascenoRafael commented Jan 20, 2021

Hey, I'm glad you liked it.

Thanks for the feedback! I hope we can find the best solutions.

1 - Do you say about the font size or the padding between the text and the surrounding area? Comparing to Apple Reminders it seems to me that the font is the same but the vertical padding should be greater. Perhaps points 2 and 3 will also help in this matter.

2 - Indeed, the current focus ring does not have an interesting look. One option would be to remove or try to make it look like the example you gave.

3 - Do you say about the focus ring? In Apple Reminders there is no overlap between the text and the icon. As stated in 2, we can place the focus ring on the outside (where there is already a border on the light theme) or simply remove the focus ring.

I liked the idea that when you open the app it automatically focuses on the text field. I think there is a workaround to change the focus using SwiftUI on macOS.

@DamascenoRafael
Copy link
Owner

Through your feedback I was thinking about a greater vertical padding, without the focus ring and some adjustments to the position of the text and icon. Like the image below:

new-textfield

What do you think?

@scottrobertson
Copy link
Contributor Author

scottrobertson commented Jan 20, 2021

Through your feedback I was thinking about a greater vertical padding, without the focus ring and some adjustments to the position of the text and icon. Like the image below:

new-textfield

What do you think?

Yes! That last one is so much better 👍

The border on the light mode still feels a little off, not sure why. Maybe have a light gray background on the text field, with no border. Similar to the dark mode, but just lighter background?

@DamascenoRafael
Copy link
Owner

I think you are right!

I also removed the dropdown border on the side.

Using the #EDEDED background this was the result:

new-text-field-light-2

@scottrobertson
Copy link
Contributor Author

Nice :) Looks much nicer without the border on the side too.

Do you think the dropdown should be the same height as the text field?

@DamascenoRafael
Copy link
Owner

I was trying a few different options. Which one looks nicer to you?

textfield-dropdown-comparison3

@scottrobertson
Copy link
Contributor Author

I was trying a few different options. Which one looks nicer to you?

textfield-dropdown-comparison3

Top right I think :)

@DamascenoRafael
Copy link
Owner

Agreed! 👍

I will commit and close this issue then.

Can you open a new issue for the other idea you gave (when you open the app, it automatically focuses on the text field)? I think this part can be a little more complicated because of SwiftUI on macOS.

@scottrobertson
Copy link
Contributor Author

Just built this locally. So much better! Thanks :)

@DamascenoRafael
Copy link
Owner

Great!! I will try to release a new version in the next few days with this change and other features 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants