Skip to content
This repository has been archived by the owner on Jun 27, 2021. It is now read-only.

Allow to specify a customised password-store path #78

Merged
merged 1 commit into from
Jan 14, 2019

Conversation

galaunay
Copy link
Contributor

@galaunay galaunay commented Jan 4, 2019

This small PR allows the user to specify a customised password-store location.
Just in case people don't use the default "~/.password-store" location.

Copy link
Owner

@DamienCassou DamienCassou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR. I like what you did and find this useful.

auth-source-pass.el Outdated Show resolved Hide resolved
@DamienCassou
Copy link
Owner

Because this package is in Emacs core now, I need you to sign the FSF papers before I can merge your code. Is that ok?

@galaunay
Copy link
Contributor Author

galaunay commented Jan 4, 2019

Thank you for the comments.
I defined the customisation group as a subgroup of auth-source.
Tell me if there is any other improvements to make.

No problem about the FSF papers, how are we supposed to proceed ?

Copy link
Owner

@DamienCassou DamienCassou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. One minor thing left and I will merge.

auth-source-pass.el Outdated Show resolved Hide resolved
@DamienCassou
Copy link
Owner

I defined the customisation group as a subgroup of auth-source.

that's great

No problem about the FSF papers, how are we supposed to proceed ?

I will merge your PR as it is small enough to be accepted even without the papers signed in my opinion. But please send a mail to assign@gnu.org and ask for the copyright assignment form.

@galaunay
Copy link
Contributor Author

Thanks,
I removed the group and sent a mail to gnu.

@galaunay galaunay closed this Jan 13, 2019
@galaunay galaunay reopened this Jan 13, 2019
Copy link
Owner

@DamienCassou DamienCassou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, thank you. Can you please squash all your commits into just one before I merge?

@galaunay
Copy link
Contributor Author

It should be clean now.

@DamienCassou DamienCassou merged commit e572c7a into DamienCassou:master Jan 14, 2019
@DamienCassou
Copy link
Owner

Thank you very much

@galaunay
Copy link
Contributor Author

Thank you for this package !

@galaunay galaunay deleted the Allow-customized-paths branch January 14, 2019 18:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants