Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export Typescript types for Operating System and Browser #115

Closed
jamzi opened this issue Jul 26, 2019 · 3 comments · Fixed by #119
Closed

Export Typescript types for Operating System and Browser #115

jamzi opened this issue Jul 26, 2019 · 3 comments · Fixed by #119

Comments

@jamzi
Copy link

jamzi commented Jul 26, 2019

Hey!. Thanks for this package, it's a lifesaver.

I was wondering if you could export Browser and OperatingSystem types from index.d.ts, so we can use them in our apps to get better type safety, instead of just comparing strings for these values.

image

@mdr
Copy link

mdr commented Sep 6, 2019

Just wanted to 👍 this -- in our app we've ended up duplicating the type declarations for Browser and OperatingSystem (which can then might drift over time from the ones used by detect-browser).

@DamonOehlman
Copy link
Owner

Super sensible request. I'll add those exports now and publish a new minor version. Apologies for the delay, I'm terrible at keeping track of my issue inbox.

@DamonOehlman
Copy link
Owner

Just published 4.7.0 which includes these types exported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants