Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Absolute path in code #59

Closed
seventer opened this issue Jul 21, 2022 · 6 comments
Closed

Absolute path in code #59

seventer opened this issue Jul 21, 2022 · 6 comments

Comments

@seventer
Copy link
Contributor

There is an absolute path in the code which makes the plugin not working if SIP is installed at another location.

sys.path.insert(0, '/home/pi/SIP/plugins/flowhelpers')

@Dan-in-CA
Copy link
Owner

Dan-in-CA commented Jul 21, 2022

Changed to:
sys.path.insert(0, './plugins/flowhelpers')
Tested with sip installed in /opt and it works now.

@seventer
Copy link
Contributor Author

Also tested and can confirm it's working fine.
Hopefully the original author (@IMHarris ) will update his own source as well.

@IMHarris
Copy link
Contributor

Thanks @seventer for the fix. I'll update my code as well. Were you able to get the full system to work?

@seventer
Copy link
Contributor Author

@IMHarris I have no flow sensor yet so I've tested with a Arduino Pro Mini, powered en connected from/to the RasPi with a rotary switch as a (manual) flow sensor. It is doing something. While rotating I see milions of liters flowing :-)
Not sure what else the plugin is doing. @Dan-in-CA also want to discuss the functionality of this plugin. Maybe it is better to open a discussion on the SIP forum then.

@Dan-in-CA
Copy link
Owner

Either the SIP forum or the Discussions sections here on GitHub. Which ever you prefer.

@IMHarris
Copy link
Contributor

Glad to hear the plugin is showing signs of life for you. Looking forward to discussing further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants