Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Libraries should target netstandard2.0 to be more versatile #317

Closed
smkanadl opened this issue Apr 29, 2022 · 7 comments
Closed

Comments

@smkanadl
Copy link

Is your feature request related to a problem? Please describe.
dwsim.org describes 'Standalone Thermo' as one of the use-cases of DWSIM. Due to the nature of the binaries being compiled for .NET 4.6.2, the usage is restricted to projects targeting the 'full' framework.

Describe the solution you'd like
As a solution, one would typically try to target either netstandard2.0 or multi-target for typical LTS-versions of the various flavours of the .NET ecosystem. That way, the Thermodynamic libraries are also usable in .NET Core and .NET5/6 projects.

@DanWBR
Copy link
Owner

DanWBR commented Apr 29, 2022

@smkanadl it is not so simple to do that given the current structure of the thermodynamics library and its dependencies (i.e. windows forms). Actually, I do have a netstandard version of the library (heavily modified, by the way) which I use in the mobile versions of DWSIM, but it is not free/open-source.

@DanWBR DanWBR closed this as completed Apr 29, 2022
@smkanadl
Copy link
Author

@DanWBR thanks for the quick response. I am aware of the implications with such a request and that it is nothing to be expected in near future.

For my potential use-case, I would not need any UI related bits but mostly the phase equilibrium/ PT flash routines. As you mentioned the netstandard version of the library is not available as open source, what would the way to get hold of it? At least for some testing/evaluation process.

Many thanks,
Kai

@DanWBR
Copy link
Owner

DanWBR commented Apr 29, 2022

@smkanadl I call it "PortableDTL", and as I've mentioned before, it is used in DWSIM for Android and iOS, which are freemium apps. Making the library portable was a huge work that I was able to accomplish years ago. It is not head-to-head with the thermo library for DWSIM for desktop, there are some parts that were not updated, i.e. the flash algorithm structure.

@DanWBR DanWBR reopened this Apr 29, 2022
@smkanadl
Copy link
Author

@DanWBR that's unfortunate as the flash algorithms are exactly the ones I would need.

@DanWBR
Copy link
Owner

DanWBR commented Jun 9, 2022

@smkanadl I have a .NET 6 version of DWSIM ready to release, but I set this as a target for GitHub sponsoring: https://github.com/sponsors/DanWBR

@smkanadl
Copy link
Author

smkanadl commented Jun 9, 2022

@DanWBR thank you very much for providing the information. I will talk to the project management and check if GitHub sponsoring is something we could do (With respect to company policies and stuff like that).

I assume that the 25$ tier would already give us access to the .NET 6 version (per the private repository DWSIM Core). Is that correct?

@DanWBR DanWBR closed this as completed Oct 27, 2022
@BorisGoryunov
Copy link

Hi,
@DanWBR how could I get access to the .NET 6 version ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants