Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NanosecondTime not exposed #31

Open
degloff opened this issue Mar 20, 2020 · 1 comment
Open

NanosecondTime not exposed #31

degloff opened this issue Mar 20, 2020 · 1 comment

Comments

@degloff
Copy link

degloff commented Mar 20, 2020

NanosecondTime is not exposed.

 Instant.epochTime(NanosecondTime(nanosecAsInt))

Is more descriptive than

Instant.fromEpochBigIntNanoseconds(BigInt.from(nanosecAsInt))

We can still keep current time in long 64 bit as for the next appox 260 years. After that I don't care anymore :)

@degloff
Copy link
Author

degloff commented Mar 20, 2020

May I also suggest to change the naming

factory Instant.fromEpochNanoseconds(int nanoseconds) => Instant.epochTime(ITime.trusted(0, nanoseconds));

Here fromEpochNanoseconds may be misleading, what about fromEpochNanosecondsInterval?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant