New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The recursive usage of group_rep_from_gens are very interesting, but once again I assume these 2 line without any variables to get the returns are redudent code #7

Open

splendidsummer opened this issue Apr 18, 2024 · 2 comments

Assignees

splendidsummer commented Apr 18, 2024

https://github.com/Danfoa/MorphoSymm/blob/29e0c0fe5281f13304437da492a7ca53d6b98595/morpho_symm/utils/rep_theory_utils.py#L91C1-L93C1

Author

splendidsummer commented Apr 18, 2024

I think I misunderstand the code here, never mind, I am going to close this stupid issue

Owner

Danfoa commented Apr 24, 2024

Good catch. Thanks @splendidsummer will update soon, or feel free to do a PR if you want to :)

Danfoa self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment