Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal support for browser #14

Closed
guyluz11 opened this issue Jan 14, 2021 · 3 comments
Closed

Minimal support for browser #14

guyluz11 opened this issue Jan 14, 2021 · 3 comments

Comments

@guyluz11
Copy link
Contributor

Not having browser support lower this pacage sore.

I am not sure what layout would I expect for action bottom sheet.

Maybe small action sheet from the bottom center that does not take all the page width if it is bigger than x.

Screenshot_20210114-125332_Firefox

@guyluz11
Copy link
Contributor Author

Did a little digging and found out about universal_io, it is like dart.io but can be used on browser too.

So we can use foundation.dart to detect web if needed and use the universal_io to detect IOS and Android without lowering the package sore.

import 'package:flutter/foundation.dart' show kIsWeb;

if (kIsWeb) {
  // running on the web!
} else {
  // NOT running on the web! You can check for additional platforms here.
}

@guyluz11
Copy link
Contributor Author

Sharing here testing with browser (code include pull request)

image
image
image

@Daniel-Ioannou
Copy link
Owner

Daniel-Ioannou commented Jan 15, 2021

I am not sure what layout would I expect for web, I am more familiar with mobile app's design guidelines and components. I test your pull request and looks ok for now.

Thank @guyluz11 for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants