Skip to content

Commit

Permalink
New post: "No errors here"
Browse files Browse the repository at this point in the history
  • Loading branch information
Daniel15 committed Dec 23, 2011
1 parent 1e88f8e commit bd9de96
Showing 1 changed file with 41 additions and 0 deletions.
41 changes: 41 additions & 0 deletions _posts/2011-12-23-no-errors-here.md
@@ -0,0 +1,41 @@
---
title: No errors here
layout: post
author: Daniel15
authorurl: http://dan.cx/
---

{% highlight javascript %}
<script type="text/javascript">
function handleError() {
return true;
}
window.onerror = handleError;
</script>
<script type="text/javascript" language="javascript">
function doCallback1(param1, param2, param3) {
Callback1.Callback(param1, param2, param3);
}
function doCallback2(param1, param2, param3) {
Callback1.Callback(param1, param2, param3);
Callback2.Callback(param1, param2, param3);
Callback3.Callback(param1, param2, param3);
}
function doCallback3(param1, param2, param3) {
Callback2.Callback(param1, param2, param3);
Callback3.Callback(param1, param2, param3);
}

function InitLocation(division) {
clbDivision.Callback(division);
}
</script>
{% endhighlight %}

I'm not sure what's worse - The fact that all JavaScript errors are silently ignored, doCallback2
having three callbacks and doCallback3 having two callbacks, or the use of globals (Callback1,
Callback2, Callback3). The same site had JavaScript functions with names like "foo" and "bar".

As a side note, an interesting oddity in JavaScript: When you return true in the window.onerror
handler, this prevents the default event handler. This is the opposite to all the other DOM 0
events (such as onclick), where returning false prevents the default handler.

0 comments on commit bd9de96

Please sign in to comment.