Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix empty column, was shifting the column values #8

Merged
merged 4 commits into from Apr 18, 2016
Merged

Fix empty column, was shifting the column values #8

merged 4 commits into from Apr 18, 2016

Conversation

regis-leray
Copy link

@regis-leray regis-leray commented Apr 18, 2016 •
edited

Currently every line or cell with empty value are skipped.
But im my case that what causing an issue !

id,timestamp,battery 
297699, ,95
297700,1448387879000,95

when i was accessing the value timestamp was having the value of 95, when it should be empty

@regis-leray
Copy link
Author

All the unit test were disable , i fix them and i add one for my specific case !

@Daniel1of1
Copy link
Owner

Amazing! Thanks again 🙇. Great test. Merging 👍

@Daniel1of1 Daniel1of1 merged commit 44a432c into Daniel1of1:master Apr 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@regis-leray @Daniel1of1