New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue #12 (Bug: default value hidden inside fragment) #18
Conversation
Thanks! Letting you know I've seen your PR and I will soon test and look at it |
RTL problem fixed in this commit, so when you click on minus in rtl mode, counter decrease. and work as expected.
Updating you that I've been prioritising some other things, sorry for that. Doing a quick scan I'm happy with most changes I see but I'll have to take a bit more time to review though. Also thanks for addressing the RTL problem |
Thank you for announcing me about this, |
Hi @nasrabadiAM, It's been a while and before I take on more issues I'm going through the Pull requests first. I want to thank you for the effort and the willingness to contribute. I have some feedback on the pull request and hope you're willing to address them, if not I can maybe split this pull request. Right now too many things happen in one pull request, I'd prefer to address one issue per pull request. This is because some of the things can be merged and some things need some work/discussion.
I currently give the feedback this way so you can make the adjustments and we can continue the discussions in separate threads afterwards but also so you will be credited for your work when things get merged. |
Coming back at my comment:
Is unfortunately not the correct way of fixing this. It'll assign a wrong initial height to the counter. I found a solution to this problem and I'm currently implementing this. For this reason I'm closing this pull request. |
I Had same problem that mentioned in this issue, and i used @VrasidasP solution and problem solved.
I replaced this line:
newHeight = measuredHeight
with this:
newHeight = if (measuredHeight == 0) newHeight else measuredHeight
.