Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android:supportsRtl="false" make error #37

Closed
mgrmaxi opened this issue Feb 2, 2019 · 3 comments
Closed

android:supportsRtl="false" make error #37

mgrmaxi opened this issue Feb 2, 2019 · 3 comments

Comments

@mgrmaxi
Copy link

mgrmaxi commented Feb 2, 2019

when a make supportsRtl="false" this error appear

Manifest merger failed : Attribute application@supportsRtl value=(false) from AndroidManifest.xml:14:9-36
is also present at [com.github.DanielMartinus:Stepper-Touch:0.6] AndroidManifest.xml:14:9-35 value=(true).
Suggestion: add 'tools:replace="android:supportsRtl"' to element at AndroidManifest.xml:9:5-27:19 to override.

@DanielMartinus
Copy link
Owner

DanielMartinus commented Feb 2, 2019

Hmm, I see that in version 0.6 indeed android:supportsRtl="true" is used in the manifest here:

android:supportsRtl="true"

Did you try adding tools:replace to you application tag in your manifest?

<application
    tools:replace="android:supportsRtl" ../>

It will override the settings of the library to use the settings of the app. It should have no problems changing that since 0.6 isn't using RTL layouts anyways. I will see if I have to remove this from the latest version also.

@DanielMartinus DanielMartinus pinned this issue Feb 2, 2019
@DanielMartinus DanielMartinus unpinned this issue Feb 2, 2019
@mgrmaxi
Copy link
Author

mgrmaxi commented Feb 3, 2019

Yes I added
<application tools:replace="android:supportsRtl" ../>
And The problem was solved
Thanks for the clarification and quick answer
I have a query on another topic.
I notice a slight slow response when you click to quickly increase or decrease the number

@DanielMartinus
Copy link
Owner

DanielMartinus commented Feb 4, 2019

Cool, thanks. Then I consider this solved. I removed the xml tag from the manifest but that'll only be fixed in the next version.

About the other topic, you mean when you tap quickly it doesn't directly count up or down? That is caused since it's waiting for the animation to be finished. I can imagine it isn't expected behavior. But let's not discuss that in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants