-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display Bedrock players #54
Conversation
Any chance of getting this in a release? I made a minor fix to WebStats-dist.js just to get it to actually displaying some stats at all:
|
This PR is pretty old and based on older code so it will need a bit of work to get it in a working (and mergeable) state again. I'm happy that there is some enthusiasm for getting bedrock to work, though! The primary reason that this wasn't merged is that I cannot test whether it works or not (I do not have a bedrock server). If you would be willing to test, I can probably get a version working somewhere this week. |
I am more than happy to test it. |
I didn't know it was that simple :) The original PR code also included a way to change the bedrock prefix (because apparently it is configurable), but for simplicity I decided to rip out that code. Should be working as it is basically just your fix as well! |
Do you have a test-release I can try? |
The latest commit has a github action that automatically builds the jar and js file. You can find it on the bottom of the action summary page, under "Artifacts". |
Thanks. Found it now, and it seems to work. edit |
Damn, I thought I had tested the github actions thing properly but apparently not... For what it's worth, here's the jar including the js file: WebStats-1.8.6-dev.zip EDIT: the newest commits have fixed the github actions artifact output: https://github.com/Dantevg/WebStats/actions/runs/6023007759 |
Closes #53