New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Capability List #102
Capability List #102
Conversation
There is a test file in this PR that should have been included in the set entry cap PR. |
Thanks! I did entry tests as well at #103. I can take care of conflicts later. |
Yep sounds good. I saw what you added and wondered why, then noticed I hadn't added my test file to the git commit properly. It also tests it via system calls etc. and will be updated by this PR anyway. That's something to note, this PR changes pretty much all tests in accordance with issue #47 where we move capabilities to a different stage of registration. |
Major features complete, remaining tasks:
|
There's a big set of questions around minting in delegation. The current PR is complete in that it completes the list above, it simply allows a procedure with the PUSH_CAP capability to add any capability, even one it does not possess. We need to restrict it so you can only delegate caps you already have, but I think this is a good point to merge and make that into a separate issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome Work! I didn't realize you had to replace all registerProcedure
calls with manual push cap calls, but that makes sense.
Yeah, it's a natural result of needing to separate the two. We could still abstract it away, but at the time there were too many different cases that they all needed changing anyway. |
This PR is to address #47, #51, and #52. Because these three will require changing how capabilities are assigned they will affect a lot of tests, and will need to be dependent on each other. I will follow this plan: