Add name management functionality for Characters and Pets #5
Conversation
Lego6245
changed the title
| <table class="table table-striped"> | ||
| <tr> | ||
| <th>Pet ID</th> | ||
| <th>Current Name</th> |
There was a problem hiding this comment.
Should this be "Custom Name" (or just "Name") to match the column header for character names?
| else: | ||
| message = 'Pet name {} approved'.format(pending_name) | ||
| else: | ||
| query = "UPDATE pet_names SET approved = 0 WHERE id = %s" |
There was a problem hiding this comment.
The server itself does not seem to support rejecting pet names yet. Unless I am missing something it only supports pending approval (1) and approved (2) at the moment, see relevant code.
Would it make sense to omit rejecting pet names for now, until that has been implemented server-side?
Otherwise it might cause issues in the future when it is implemented for the server but they chose a different implementation, other than using value 0 to represent renaming required.
There was a problem hiding this comment.
The server itself does not seem to support rejecting pet names yet. Unless I am missing something it only supports pending approval (1) and approved (2) at the moment, see relevant code.
Would it make sense to omit rejecting pet names for now, until that has been implemented server-side? Otherwise it might cause issues in the future when it is implemented for the server but they chose a different implementation, other than using value 0 to represent renaming required.
The server does support rejecting names. Changing the approved value to 0 rejects the name, and forces the user to rename the pet when they bring it out next.
However, that being said, it does NOT support forcing a user to rename a pet that's already been approved. To accomplish this, you need to set a 0 in the pet_names table AND set a 0 on the m tag in the respective pet tag in the user's xml data.
There was a problem hiding this comment.
Thank you for the clarification!
However, that being said, it does NOT support forcing a user to rename a pet that's already been approved.
This might not be an issue (for now) because if I understand these changes correctly, only unapproved pet names are displayed. So unless you are manually editing the database to change an already approved name back to unapproved, this situation should not occur.
(Though @Lego6245 can probably answer that better.)
There was a problem hiding this comment.
Correct on all counts.
While there is no reference in server code, in client code, it handles the state of '0' correctly.
Only pending names are shown. There is no way to re-force a name to be approved (currently).
|
|
||
| {% if names %} | ||
| <h3>Character Names</h3> | ||
| <table class="table table-striped"> |
There was a problem hiding this comment.
What do you think about including some default text like "No pending approvals" when there are neither pending character name nor pet name approvals?
This would make it a little bit more obvious why the page is empty.
Though I am not a member of this project, so feel free to just ignore that suggestion.
|
Nexus Dashboard has this functionality and is tested, Do you will want to get this in the app or just use the new app? |
|
See Nexus Dashboard for this functionality and more |
The following PR adds the approve_names route, which pulls all names that are still pending, and allows a GM user to either approve or reject names, updating them in the DB.
Open question: Is this the correct way to do name approval? Does anything else need to happen for it to work correctly?
Fixes #2
Fixes #8