Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential Bug Risks and Anti-Patterns #8

Closed
HarshCasper opened this issue Feb 21, 2021 · 4 comments
Closed

Potential Bug Risks and Anti-Patterns #8

HarshCasper opened this issue Feb 21, 2021 · 4 comments

Comments

@HarshCasper
Copy link
Contributor

Description

Hi @DarshanDeshpande 馃憢

I ran DeepSource Static Code Analysis upon the Project, the results for which are available here.

The Static Code Analysis Tool found potential bugs and anti-patterns in the Code, that can be detrimental at a later point in time with respect to the Project. DeepSource helps you to automatically find and fix issues in your code during code reviews. This tool looks for anti-patterns, bug risks, performance problems, and raises issues.

Some of the notable issues are:

  • Missing Arguement in Function Call (here)
  • Unnecessary Generator (here)
  • f-string used without any expression (here)
  • Detected subprocess popen call with shell equals True (here)
  • Bad Expect Order (here)

There are plenty of other issues in relation to Bug Discovery and Anti-Patterns which you would be interested to take a look at.

If you would like to integrate DeepSource to autofix some of the common occurring issues, I can help you set that up :)

@DarshanDeshpande
Copy link
Owner

Yes I know that some code cleaning is required. This analysis seems interesting. We could use a tool like this for future proofing

@HarshCasper
Copy link
Contributor Author

Yes I know that some code cleaning is required. This analysis seems interesting. We could use a tool like this for future proofing

Hi @DarshanDeshpande 馃憢

Shall I raise a PR for the same and provide some cleanup with the Autofix tool? It would be a good way to judge the efficiency of the tool.

@DarshanDeshpande
Copy link
Owner

Yes that sounds good

@DarshanDeshpande
Copy link
Owner

PR Merged. Closing this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants