New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sentry error reporting #128

Merged
merged 2 commits into from Jan 14, 2019

Conversation

2 participants
@koenpunt
Copy link
Contributor

koenpunt commented Jan 11, 2019

This PR adds support for logging error to Sentry.

The Sentry client already supports setup using environment variables (when the library is included a default client is created using them), but I'm not sure if we want to rely on that from within imgproxy, so I created a dedicated client instead.

Alternative would be to use the default client, but configure it using the imgproxy config.

Nevermind, I'm using the default client now.

Fixes #125

@koenpunt koenpunt force-pushed the koenpunt:sentry-error-reporting branch 2 times, most recently from 072c269 to 1b0e0f3 Jan 11, 2019

@koenpunt koenpunt force-pushed the koenpunt:sentry-error-reporting branch from 1b0e0f3 to 518336d Jan 11, 2019

@DarthSim

This comment has been minimized.

Copy link
Owner

DarthSim commented Jan 11, 2019

Looks great to me, thanks!

Please, fix the link to the error reporting section in README. It became broken when you changed the header

@koenpunt koenpunt force-pushed the koenpunt:sentry-error-reporting branch from 570123b to 0dc586d Jan 11, 2019

@koenpunt koenpunt force-pushed the koenpunt:sentry-error-reporting branch from 0dc586d to e73bca2 Jan 11, 2019

@koenpunt

This comment has been minimized.

Copy link
Contributor

koenpunt commented Jan 11, 2019

Done!

@DarthSim DarthSim merged commit 575960e into DarthSim:master Jan 14, 2019

16 checks passed

ci/circleci: checkout_code Your tests passed on CircleCI!
Details
ci/circleci: go1.10_vips8.3 Your tests passed on CircleCI!
Details
ci/circleci: go1.10_vips8.4 Your tests passed on CircleCI!
Details
ci/circleci: go1.10_vips8.5 Your tests passed on CircleCI!
Details
ci/circleci: go1.10_vips8.6 Your tests passed on CircleCI!
Details
ci/circleci: go1.10_vips8.7-1 Your tests passed on CircleCI!
Details
ci/circleci: go1.10_vips8.7-2 Your tests passed on CircleCI!
Details
ci/circleci: go1.11_vips8.3 Your tests passed on CircleCI!
Details
ci/circleci: go1.11_vips8.4 Your tests passed on CircleCI!
Details
ci/circleci: go1.11_vips8.5 Your tests passed on CircleCI!
Details
ci/circleci: go1.11_vips8.6 Your tests passed on CircleCI!
Details
ci/circleci: go1.11_vips8.7 Your tests passed on CircleCI!
Details
ci/circleci: go1.9_vips8.3 Your tests passed on CircleCI!
Details
ci/circleci: go1.9_vips8.4 Your tests passed on CircleCI!
Details
ci/circleci: go1.9_vips8.5 Your tests passed on CircleCI!
Details
ci/circleci: go1.9_vips8.6 Your tests passed on CircleCI!
Details
@DarthSim

This comment has been minimized.

Copy link
Owner

DarthSim commented Jan 14, 2019

Merged. Thanks for your contribution again!

@koenpunt koenpunt deleted the koenpunt:sentry-error-reporting branch Jan 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment