Add Sentry error reporting #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koenpunt
force-pushed
the
sentry-error-reporting
branch
2 times, most recently
from
072c269
to
1b0e0f3
Compare
koenpunt
force-pushed
the
sentry-error-reporting
branch
from
1b0e0f3
to
518336d
Compare
|
Looks great to me, thanks! Please, fix the link to the error reporting section in README. It became broken when you changed the header |
koenpunt
force-pushed
the
sentry-error-reporting
branch
from
570123b
to
0dc586d
Compare
koenpunt
force-pushed
the
sentry-error-reporting
branch
from
0dc586d
to
e73bca2
Compare
|
Done! |
|
Merged. Thanks for your contribution again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for logging error to Sentry.
The Sentry client already supports setup using environment variables (when the library is included a default client is created using them), but I'm not sure if we want to rely on that from within imgproxy, so I created a dedicated client instead.Alternative would be to use the default client, but configure it using the imgproxy config.Nevermind, I'm using the default client now.
Fixes #125